213281 - make mozilla build with mingw gcc on win98 (windres no resources error)

Status: RESOLVED FIXED

(SeaMonkey :: Build Config, defect)

Description

[Sander]

Trying to build mozilla with mingw gcc on win98, I consistently rand into the
problem of windres giving a "no resources" error:

Creating Resource file: module.res
sh /cygdrive/e/building/home/mozilla/build/cygwin-wrapper windres -O coff
-DOSTYPE=\"WINNT4.0\" -DOSARCH=\"WINNT\" -D_IMPL_NS_COM -DEXPORT_XPT_API
-DEXPORT_XPTC_API -DEXPORT_XPTI_API --include-dir .. --include-dir
e:/building/home/mozilla/xpcom/build/../glue --include-dir
e:/building/home/mozilla/xpcom/build/../base --include-dir
e:/building/home/mozilla/xpcom/build/../ds --include-dir
e:/building/home/mozilla/xpcom/build/../io --include-dir
e:/building/home/mozilla/xpcom/build/../components --include-dir
e:/building/home/mozilla/xpcom/build/../threads --include-dir
e:/building/home/mozilla/xpcom/build/../threads/_xpidlgen --include-dir
e:/building/home/mozilla/xpcom/build/../proxy/src --include-dir
../../dist/include/string --include-dir ../../dist/include/xpcom --include-dir
../../dist/include --include-dir ../../dist/include/nspr -o module.res module.rc
Bad command or file name
e:\BUILDING\MINGW\BIN\windres.exe: no resources
make[4]: *** [module.res] Error 1


According to http://groups.google.com/groups?selm=114.1d19a26.28870de5%40aol.com
and followup, the error is windows' and the fix would be to use --use-temp-file
with windres. Adding this to  "RCFLAGS = -O coff"  in config/autoconf.mk seems
to fix. 
A proper patch will follow shortly.

Comment 1

[Sander]

Attachment: probable patch

So after futilly trying to diff against autoconf.mk for a bit, I figured out
that it's created during the build process. Both configure and configure.in
seem to define the flags for windres, so I've edited them both. 
autoconf.mk is now indeed created with --use-temp-file, so that seems to work
okay, but I have basically no idea what I'm doing here, so don't hit me too
hard if this isn't the right way or if I should've edited only one of the two
files. :)

I haven't yet succeeded in completing a build. But with this change at least
that windres error is being avoided.

Comment 2

[cls]

FWIW, I just ran into this problem on Win2000 when generating nspr.res.  I
haven't pinpointed the cause.  It only seemed to happen when building over a ssh
connection.  When I built from a local command window, then it worked fine.

Comment 3

[cls]

Attachment: nspr & ldap too

Comment 4

[Wan-Teh Chang]

Comment on attachment 128796 [details] [diff] [review]
nspr & ldap too

r=wtc.

Comment 5

[Daniel (Leaf) Nunes]

Comment on attachment 128155 [details] [diff] [review]
probable patch

rs=leaf

Comment 6

[cls]

Attachment: coreconf as well

Comment 7

[Wan-Teh Chang]

Comment on attachment 131476 [details] [diff] [review]
coreconf as well

r=wtc.

I've checked in this patch on the NSS trunk (NSS 3.9),
NSS_3_8_BRANCH (NSS 3.8.2), and NSS_CLIENT_TAG (Mozilla
1.6 alpha).

Comment 8

[cls]

The patches have all been checked in: 
mozilla trunk
nspr trunk
ldap trunk
nspr NSPRPUB_PRE_4_2_CLIENT_BRANCH
ldap ldapcsdk_50_client_branch