213549 - regxpcom thinks SelfRegisterDll FAILED = successful registration.

Status: RESOLVED FIXED

(Core :: XPCOM, defect)

Description

[timeless]

$ ./run-mozilla.sh ./regxpcom components/libxpcomsample-linux.so
nsNativeComponentLoader: SelfRegisterDll(libxpcomsample-linux.so) Load FAILED
with error:Not an executable
Registration successful for components/libxpcomsample-linux.so   

mozhack@boffo:~/obj-i686-pc-linux-gnu-qt/dist/bin$ ./run-mozilla.sh ./regxpcom
components/libxpcomsample-beos.so
Type Manifest File:
/mnt/ibm/mozhack/obj-i686-pc-linux-gnu-qt/dist/bin/components/xpti.dat
nsNativeComponentLoader: SelfRegisterDll(libxpcomsample-beos.so) Load FAILED
with error:libbe.so: cannot open shared object file: No such file or directory
Registration successful for components/libxpcomsample-beos.so
mozhack@boffo:~/obj-i686-pc-linux-gnu-qt/dist/bin$

Comment 1

[timeless]

mine

Comment 2

[timeless]

Attachment: store registration failure and return successful registration

$ ./run-mozilla.sh ./regxpcom components/*linux*
nsNativeComponentLoader: SelfRegisterDll(libxpcomsample-linux.so) Load FAILED
with error: Not an executable
Registration failed: (80040154) components/libxpcomsample-linux.so

Comment 3

[Doug Turner (:dougt)]

wouldn't it be better if you just check for didRegister at the end of
AutoRegisterComponent and it if is false, return NS_ERROR_FACTORY_NOT_REGISTERED:

return (NS_FAILED(rv) || !didRegister) ? NS_ERROR_FACTORY_NOT_REGISTERED : NS_OK;

Comment 4

[timeless]

that won't work. the problem is that rv is failed because some other loader (js)
set it that way. so you'd have:

if (failed[which js did] or didn'tregister [ false, native registered] ==> true)
=> return failure => same as current state.

Comment 5

[Doug Turner (:dougt)]

Comment on attachment 128504 [details] [diff] [review]
store registration failure and return successful registration

youre right.  check it in.

Comment 6

[timeless]

checked in