Closed
Bug 213735
Opened 22 years ago
Closed 22 years ago
new bookmark/bookmark properties dialog should stay LTR when UI is right to left
Categories
(Core :: Layout: Text and Fonts, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: tsahi_75, Assigned: simmo)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
|
785 bytes,
patch
|
mkaply
:
review+
jag+mozilla
:
superreview+
|
Details | Diff | Splinter Review |
User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; he-IL; rv:1.4) Gecko/20030624 Netscape/7.1 (ax)
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; he-IL; rv:1.4) Gecko/20030624 Netscape/7.1 (ax)
Description: when the interface is aligned to the right, e.g. when using a RTL
language (like hebrew or arabic), in the dialog box for a new bookmark
(bookmarks manager > file > new > bookmark) or bookmark properties (edit >
properties), the location field is also RTL. even after the standard for domain
names in non-latin characters is approved, the TLDs, SLDs and the rest of the
URL will remain in latin characters, so it is logical to have this field stay in
LTR even with a RTL language pack.
Reproducible: Always
Steps to Reproduce:
1.aligning the interface to the right: add these lines to the file intl.css, in
the locale\en-US\global, in the en-US.jar file (the language pack file, in the
chrome folder):
/*make UI RTL */
window,dialog,wizard,page { direction: rtl; }
menu { direction: rtl; }
outliner { direction: rtl; }
/*
* make sure search from address bar remains in RTL
*/
#urlbar .autocomplete-search-engine
{
direction: rtl !important;
}
/*
* keep Composer <HTML> Source tab LTR
*/
#content-source,
#doctype-text { direction: ltr; }
2.start mozilla.
3. go to the mentioned dialog box
Actual Results:
location field is RTL
Expected Results:
location field should be LTR
smontagu already fixed a similar problem for most other URL fields throughout
the UI. see bug 157607.
|
Assignee | |
Comment 1•22 years ago
|
||
easy fix, was missed in 157607
Status: UNCONFIRMED → NEW
Component: Bookmarks → BiDi Hebrew & Arabic
Ever confirmed: true
|
|
Assignee | |
Comment 2•22 years ago
|
||
|
Reporter | |
Comment 3•22 years ago
|
||
who's doing review?
|
|
Reporter | |
Comment 4•22 years ago
|
||
allright, where should i look for review?
|
||
Comment 5•22 years ago
|
||
Comment on attachment 128437 [details] [diff] [review]
should do the trick
r=mkaply
Attachment #128437 -
Flags: review+
|
||
Updated•22 years ago
|
Attachment #128437 -
Flags: superreview+
|
|
Reporter | |
Updated•22 years ago
|
Flags: blocking1.5?
Flags: blocking1.4.2?
|
||
Comment 6•22 years ago
|
||
wouldn't hold the release for this but we'd take the patch if someone can land
it quickly.
Flags: blocking1.5? → blocking1.5-
|
|
Reporter | |
Comment 7•22 years ago
|
||
would somebody please check this in?
|
|
||
Comment 8•22 years ago
|
||
Comment on attachment 128437 [details] [diff] [review]
should do the trick
fix checked in.
|
|
||
Comment 10•22 years ago
|
||
marking FIXED
Status: NEW → RESOLVED
Closed: 22 years ago
Resolution: --- → FIXED
|
|
||
Comment 11•22 years ago
|
||
I don't think we need to worry about this stuff for 1.4 anymore.
If someone thinks different, please let me know.
Flags: blocking1.4.2? → blocking1.4.2-
Component: Layout: BiDi Hebrew & Arabic → Layout: Text
QA Contact: chrispetersen → layout.fonts-and-text
You need to log in
before you can comment on or make changes to this bug.
Description
•