213882 - consider making aFileExt the primary extension if it is an extension

Status: RESOLVED FIXED

(Core Graveyard :: File Handling, defect, P3)

Description

[Christian :Biesinger (don't email me, ping me on IRC)]

bz mentioned this in bug 147679 comment 41:
"Do we want to list anything here as far as the return value?  Like
that we guarantee the return value will have [...] aFileExt as the
primaryExtension if that's a valid
extension for aMIMEType?"

After thinking about this some, and seeing the callers, I agree that this would
be a good idea.

This would basically include moving this code:
  PRBool matches = PR_FALSE;
  if (!fileExtension.IsEmpty()) {
    mimeInfo->ExtensionExists(fileExtension.get(), &matches);
  }
  if (matches) {
    mimeInfo->SetPrimaryExtension(fileExtension.get());
  }
from nsExternalHelperAppService::DoContent to GetFromTypeAndExtension

and it would allow changing that part of the code in DoContent to just
"mimeInfo->GetPrimaryExtension(getter_Copies(fileExtension))"

Comment 1

[Boris Zbarsky [:bzbarsky]]

*** Bug 213893 has been marked as a duplicate of this bug. ***

Comment 2

[Boris Zbarsky [:bzbarsky]]

*** Bug 213892 has been marked as a duplicate of this bug. ***

Comment 3

[Boris Zbarsky [:bzbarsky]]

*** Bug 213887 has been marked as a duplicate of this bug. ***

Comment 4

[Boris Zbarsky [:bzbarsky]]

*** Bug 213883 has been marked as a duplicate of this bug. ***

Comment 5

[Boris Zbarsky [:bzbarsky]]

*** Bug 213884 has been marked as a duplicate of this bug. ***

Comment 6

[Boris Zbarsky [:bzbarsky]]

*** Bug 213885 has been marked as a duplicate of this bug. ***

Comment 7

[Boris Zbarsky [:bzbarsky]]

*** Bug 213888 has been marked as a duplicate of this bug. ***

Comment 8

[Boris Zbarsky [:bzbarsky]]

*** Bug 213889 has been marked as a duplicate of this bug. ***

Comment 9

[Boris Zbarsky [:bzbarsky]]

*** Bug 213890 has been marked as a duplicate of this bug. ***

Comment 10

[Boris Zbarsky [:bzbarsky]]

*** Bug 213891 has been marked as a duplicate of this bug. ***

Comment 11

[Christian :Biesinger (don't email me, ping me on IRC)]

Attachment: patch

Comment 12

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 128523 [details] [diff] [review]
patch

Looks good.

Comment 13

[Travis Chase]

how did all those duplicates get posted? :P

Comment 14

[Christian :Biesinger (don't email me, ping me on IRC)]

Checking in nsExternalHelperAppService.cpp;
/cvsroot/mozilla/uriloader/exthandler/nsExternalHelperAppService.cpp,v  <-- 
nsExternalHelperAppService.cpp
new revision: 1.206; previous revision: 1.205
done