213899 - disable encoders for X11core fonts (in ucvcn and ucvtw2) on non-Unix

Status: RESOLVED FIXED

(Core :: Internationalization, defect)

Description

[Jungshik Shin]

This is a follow-up to bug 180851, in which I removed encoders exclusively used
for X11 core fonts. I didn't realize that GB18030Font0 (gb18030.2000-0) and
GB18030Font1 (gb18030.2000-1) encoders are ONLY for X11 core fonts as well (see
http://bugs.xfree86.org/show_bug.cgi?id=441). Disabling two encoders on non-Unix
builds would save us ~1kB(?). The patch is coming up (I'm away from my build
system at the moment) in several hours :-)

Comment 1

[Jungshik Shin]

forgot to assign to myself

Comment 2

[Jungshik Shin]

Attachment: a patch

This should work, but I have yet to test it on Win2k.

Comment 3

[Jungshik Shin]

In the patch, I also removed GB2312GL encoder because it's only used for X11
core fonts with gb2312.1980-0 (charset-registry). 

Comment 4

[Jungshik Shin]

Attachment: CNS 11643 encoders are also disabled

In addition to GB18030Font[0-1] and GB2312 GL encoders, CNS 11643 p[1-7]
converters are disabled. They're only necessary for X11core fonts and
MacOS/Windows don't need them. With this patch, the size of Win32 opt. build 
was cut down by 7kB. It's not huge, but 7kB is still worth cutting down.

Comment 5

[Alec Flett]

Comment on attachment 128709 [details] [diff] [review]
CNS 11643 encoders are also disabled

sr=alecf

Comment 6

[Simon Montagu :smontagu]

Comment on attachment 128709 [details] [diff] [review]
CNS 11643 encoders are also disabled

r=smontagu

Comment 7

[Jungshik Shin]

fix checked in to the trunk (mZ dropped by ~4kB after my checkin). thanks.