213903 - unused variables in pcertdb.c

Status: RESOLVED FIXED

(NSS :: Libraries, defect)

Description

[timeless]

/swap/BEOS/mozilla/security/nss/lib/softoken/pcertdb.c: In function
`nsslowcert_UpdateSubjectEmailAddr':
/swap/BEOS/mozilla/security/nss/lib/softoken/pcertdb.c:2665: warning: unused
variable `delold'
/swap/BEOS/mozilla/security/nss/lib/softoken/pcertdb.c:2665: warning: unused
variable `save'
/swap/BEOS/mozilla/security/nss/lib/softoken/pcertdb.c: In function
`nsslowcert_SaveSMimeProfile':
/swap/BEOS/mozilla/security/nss/lib/softoken/pcertdb.c:5238: warning: unused
variable `entry'

Comment 1

[timeless]

Attachment: remove unused variables and replace tabs with spaces

Comment 2

[Wan-Teh Chang]

Bishakha, please remove the unused variables, but don't
replace the tabs with spaces.

Comment 3

[Bishakha Banerjee]

Patch id=128516 does more than remove unused variables and change tabs to spaces.
Specifically, the following lines:

-    if (emailAddr) { 
-	emailAddr = nsslowcert_FixupEmailAddr(emailAddr);
-	if (emailAddr == NULL) {
-	    return SECFailure;
-	}
-    } else {
-	return SECSuccess;
+    if (!emailAddr) { 
+        return SECSuccess;
+    }
+    emailAddr = nsslowcert_FixupEmailAddr(emailAddr);
+    if (emailAddr == NULL) {
+        return SECFailure;
     }

Checking in per wtc the following patch that just removes unused varaibles.
retrieving revision 1.45
diff -u -r1.45 pcertdb.c
--- pcertdb.c   5 Mar 2003 01:02:03 -0000       1.45
+++ pcertdb.c   28 Jul 2003 22:52:03 -0000
@@ -2662,7 +2662,6 @@
 nsslowcert_UpdateSubjectEmailAddr(NSSLOWCERTCertDBHandle *dbhandle,
        SECItem *derSubject, char *emailAddr, nsslowcertUpdateType updateType)
 {
-    PRBool save = PR_FALSE, delold = PR_FALSE;
     certDBEntrySubject *entry = NULL;
     int index = -1, i;
     SECStatus rv;
@@ -5235,7 +5234,6 @@
 nsslowcert_SaveSMimeProfile(NSSLOWCERTCertDBHandle *dbhandle, char *emailAddr,

        SECItem *derSubject, SECItem *emailProfile, SECItem *profileTime)
 {
-    certDBEntrySMime *entry = NULL;
     SECStatus rv = SECFailure;;

     rv = db_BeginTransaction(dbhandle->permCertDB);

Comment 4

[Bishakha Banerjee]

Patch checked in:

Checking in pcertdb.c;
/cvsroot/mozilla/security/nss/lib/softoken/pcertdb.c,v  <--  pcertdb.c
new revision: 1.46; previous revision: 1.45
done

Comment 5

[timeless]

sorry about that, it's a habbit, the logic in that block was convoluted.