214048 - accounts out of order in mail-news folder pane

Status: RESOLVED FIXED

(SeaMonkey :: MailNews: Message Display, defect)

Description

[K Chayka]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.5b) Gecko/20030726
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.5b) Gecko/20030726

The order of accounts listed in the mail-news folder pane seems completely
random.  They list in the expected order in the mail-news account prefs window,
per the order specified in prefs.js mail.accountmanager.accounts, separated by
mail and news. 

Reproducible: Always

Steps to Reproduce:
1. multiple pop accounts
2. multiple news accounts
3. 

Actual Results:  
Folder pane lists order:
news-2, mail-1, mail-3, news-3, mail-3, news-1, Local folders, mail-2, mail-5

Expected Results:  
List folder pane in the same order as prefs:
mail(1-5), Local Folders, news(1-3)

Seems to have started with the 072504 build.  Win32 build 072404 is OK.

Comment 1

[Bob Kavula]

Ditto, I downloaded the 7/26 build (7/20 previous) and my account order got
jumbled.   I looked at the pref.js to see if I could straighten it out but no
luck.  Any thoughts?

Comment 2

[Matthias Versen [:Matti]]

is this a regression from bug 213768 ?

Comment 3

[David :Bienvenu]

no, bug 213768 is about the thread pane, and this is about the folder pane. Not
related.

Comment 4

[José Jeria]

I know that bugzilla is not for thunderbird, but anyway, i saw this bug too,
then i downloaded the latest thunderbird and I dont see this anymore. Maybe
mscott  knows anything about this?

Comment 5

[David :Bienvenu]

my thunderbird build from yesterday had this problem so I'm not sure this has
been fixed in thunderbird. My Mozilla build just developed the same problem when
I updated my tree outside the mailnews directory. My guess is that this is an
outliner/rdf problem, and not a mailnews problem per se. I'll try to figure out
what changed.

Comment 6

[David :Bienvenu]

OK, I strongly suspect this is fallout from the recent collation key cleanup -
nsCollationWin::CompareString is failing when we're trying to sort the folder
pane, in particular, CompareStringW is returning 0. I'll investigate more.

Comment 7

[David :Bienvenu]

Attachment: proposed fix

this fixes it for me. LCMAP_SORTKEY isn't a valid flag to CompareStringW

Comment 8

[David :Bienvenu]

Neil, can you r=? thx.

Comment 9

[[e-mail]]

Comment on attachment 128712 [details] [diff] [review]
proposed fix

Yeah, I spotted that earlier while looking at a completely different issue but
it didn't click, probably because of the lateness of the hour :-)

Comment 10

[David :Bienvenu]

fix checked in.

Comment 11

[Matthias Versen [:Matti]]

*** Bug 214257 has been marked as a duplicate of this bug. ***