214063 - Compiler warnings in <nsMsgFolder.cpp>, <nsMsgProtocol.cpp>, <wallet.cpp>: "defined but not used"

Status: RESOLVED FIXED

(SeaMonkey :: General, defect)

Description

[Matthias Bockelkamp]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.5b) Gecko/20030724
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.5b) Gecko/20030724

When compiling I get the following warnings:

e:/Mozilla/mozilla/mailnews/base/util/nsMsgFolder.cpp:367: warning: `nsresult
   nsFilterBy(nsISupportsArray*, PRBool (*)(nsISupports*, void*), void*,
   nsISupportsArray**)' defined but not used

e:/Mozilla/mozilla/mailnews/base/util/nsMsgProtocol.cpp:1371: warning: `
   PRUnichar* GetStringByID(int)' defined but not used

e:/Mozilla/mozilla/extensions/wallet/src/wallet.cpp:107: warning: `const
   char*pref_WalletExtractTables' defined but not used
e:/Mozilla/mozilla/extensions/wallet/src/wallet.cpp:116: warning: `const
   char*pref_WalletServer' defined but not used
e:/Mozilla/mozilla/extensions/wallet/src/wallet.cpp:117: warning: `const
   char*pref_WalletVersion' defined but not used
e:/Mozilla/mozilla/extensions/wallet/src/wallet.cpp:118: warning: `const
   char*pref_WalletLastModified' defined but not used
e:/Mozilla/mozilla/extensions/wallet/src/wallet.cpp:125: warning: `
   char*wallet_Server' defined but not used
e:/Mozilla/mozilla/extensions/wallet/src/wallet.cpp:1186: warning: `void
   wallet_Put(nsOutputFileStream&, char)' defined but not used


Reproducible: Always

Steps to Reproduce:
1.
2.
3.

Comment 1

[Matthias Bockelkamp]

Attachment: Patch for nsMsgFolder.cpp [Checked in: Comment 7]

Comment 2

[Matthias Bockelkamp]

Attachment: Patch for nsMsgProtocol.cpp [Checked in: Comment 7]

Comment 3

[Matthias Bockelkamp]

Attachment: Patch for wallet.cpp [Check-in: See comment 8]

Comment 4

[Daniel Veditz [:dveditz]]

Comment on attachment 128627 [details] [diff] [review]
Patch for wallet.cpp
[Check-in: See comment 8]

r=dveditz

Comment 5

[Daniel Veditz [:dveditz]]

Comment on attachment 128626 [details] [diff] [review]
Patch for nsMsgProtocol.cpp [Checked in: Comment 7]

You need a mailnews reviewer for these two

Comment 6

[Scott MacGregor]

Comment on attachment 128626 [details] [diff] [review]
Patch for nsMsgProtocol.cpp [Checked in: Comment 7]

I did an lxr search on both of these routines to make sure they weren't called
by anyone. There were a lot of possible matches for GetStringByID.

Please go through that list and make sure we really aren't using this method
anymore before checking in.

Thanks!

(Just because it is unused on one platform doesn't mean it isn't getting called
on another =)).

Comment 7

[Scott MacGregor]

I've checked in the patches for nsMsgFolder and nsMsgProtocol

Comment 8

[Serge Gautherie (:sgautherie)]

Comment on attachment 128627 [details] [diff] [review]
Patch for wallet.cpp
[Check-in: See comment 8]


Check in: { 1.354	timeless%mozdev.org	2003-10-29 18:04	       
Bug 204184 Remove unused items from wallet.cpp/wallet.h
r=dwitte sr=bryner }