214116 - Lots of references to Netscape Webmail in the Mailnews Section of Help Window.

Status: VERIFIED FIXED

(SeaMonkey :: Help Documentation, defect)

Description

[R.J. Keller]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.5b) Gecko/20030727
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.5b) Gecko/20030727

In the Mozilla Help window, there are references to AOL Mail and Netscape
WebMail. This is correct for Netscape, but Mozilla does not support Netscape
WebMail or AOL Mail. These references should be removed.

I have a patch that I will attach.

Reproducible: Always

Steps to Reproduce:

Comment 1

[R.J. Keller]

Attachment: Patch

This should remove all references to Netscape WebMail and AOL Mail.

Note that this is my first patch, so if I have done something incorrectly, I
deeply apologize.

Comment 2

[Matthias Versen [:Matti]]

-> NEW

Please ask me (via mail) in 2 weeks if you get no repsonse.
I don't know if oeschger is still there.

Comment 3

[R.J. Keller]

Attachment: Patch 2

Sorry, forgot to diff all of the files. This patch is with everything that I
forgot to diff. Also contains some more Netscape/AOL stuff I've found while
searching through it.

Comment 4

[Daniel Wang]

*** This bug has been marked as a duplicate of 210796 ***

Comment 5

[Matthias Versen [:Matti]]

don't dupe a bug with a patch

Comment 6

[Matthias Versen [:Matti]]

*** Bug 210796 has been marked as a duplicate of this bug. ***

Comment 7

[Ian Oeschger (gone)]

Comment on attachment 128660 [details] [diff] [review]
Patch 2

r=oeschger

Comment 8

[Christian :Biesinger (don't email me, ping me on IRC)]

Thanks for the patch, I just checked it in:

Checking in resources/locale/en-US/help-index1.rdf;
/cvsroot/mozilla/extensions/help/resources/locale/en-US/help-index1.rdf,v  <-- 
help-index1.rdf
new revision: 1.5; previous revision: 1.4
done
Checking in resources/locale/en-US/help-toc.rdf;
/cvsroot/mozilla/extensions/help/resources/locale/en-US/help-toc.rdf,v  <-- 
help-toc.rdf
new revision: 1.24; previous revision: 1.23
done
Checking in resources/locale/en-US/mail_help.html;
/cvsroot/mozilla/extensions/help/resources/locale/en-US/mail_help.html,v  <-- 
mail_help.html
new revision: 1.15; previous revision: 1.14
done

Comment 9

[Jord van der Elst]

Thanks for confusing me, Matti, about who posted the bug first. :)

No hard feelings, I only saw today I had 1.5b, with still the same problem, so
you called it right. Will tonight go for the new nightly that should be fixed.

Jord.

Comment 10

[R.J. Keller]

Could we get this on the 1.4 branch?

Comment 11

[R.J. Keller]

For 1.4 branch drivers:

Benefits - Takes out Help information about AOL Mail and Netscape WebMail, which
don't exist. We won't be containing false information in the Help menu and won't
make the user think that something exists when it doesn't.

Risk - The most, if any, is to have a dead link from another help file linking
to AOL Mail/NS WebMail (which is very unlikely!). That might actually be better
though since you're not leading a user through steps that don't exist.

Comment 12

[R.J. Keller]

Verified 20030731 on Windows XP and Mandrake Linux 9

Comment 13

[Matthias Versen [:Matti]]

Please never verify your own bug fixes !

Comment 14

[Asa Dotzler [:asa]]

Comment on attachment 128660 [details] [diff] [review]
Patch 2

a=asa (on behalf of drivers) for checkin to the 1.4 branch.

Comment 15

[R.J. Keller]

oeschger - could you get this on the 1.4 branch?

Comment 16

[Mike Kaply [:mkaply]]

Comment on attachment 128660 [details] [diff] [review]
Patch 2

I'd prefer not to take this for 1.4.1 because of translation issues.

We might open 1.4.2 a little wider and take this stuff.

Comment 17

[R.J. Keller]

Reopening for 1.4 branch work.

Comment 18

[R.J. Keller]

--> me

Comment 19

[R.J. Keller]

OK, this patch would work.

Sorry for the spam, guys.

Comment 20

[Daniel Wang]

v

Comment 21

[Mike Kaply [:mkaply]]

Comment on attachment 128660 [details] [diff] [review]
Patch 2

I'll take this for 1.4.2 because the translation impact doesn't actually break
code.

The translation stuff we don't want would be DTD and properties changes.

Comment 22

[R.J. Keller]

Fix checked in on 1.4 branch.