214152 - Crash (Sys3175) when opening URL as bookmarklet

Status: RESOLVED FIXED

(SeaMonkey :: General, defect)

Description

[amai]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.5a) Gecko/20030718
Build Identifier: http://ftp.mozilla.org/pub/mozilla/releases/mozilla1.4/mozilla-os2-vacpp-1.4.zip

I drag that link in the toolbar and click on it.
Same if the link is to the same HTML source but on a local file.

Reproducible: Always

Steps to Reproduce:
1. 
2.
3.



Expected Results:  
Not crash, but display passwords in forms on current page

Comment 1

[amai]

Sorry for omitting some information on the initial report.
I can supply the exact crash info later today.

Comment 2

[Phil Schwartau]

---> Browser-General until we can get a stack trace

Comment 3

[Mike Kaply [:mkaply]]

Taking

Comment 4

[Mike Kaply [:mkaply]]

Attachment: Workaround for problem

The actual bug here appears to be that UniUconvFromUcs is failing with a long
string.

However, the NS_NewLocalFile API should be smart enough to handle this failing
case, and not just return NS_OK all the time.

Comment 5

[Mike Kaply [:mkaply]]

Attachment: Better fix

I took the linux code which is a little better and also put a patch for
Windows.

Comment 6

[amai]

Ok, looks like a good part of the work already done :-)
 --> Thanks!

Just for completness the precise crash info:

Mozilla/5.0 (OS/2; U; Warp 4.5; en-US; rv:1.4) Gecko/20030724

07-28-2003  20:42:25  SYS3175  PID 002a  TID 0001  Slot 0069
E:\APPS\MOZILLA\PM\BIN\MOZILLA.EXE
c0000005
1def5d25
P1=00000001  P2=00000000  P3=XXXXXXXX  P4=XXXXXXXX  
EAX=00000000  EBX=00000000  ECX=0014e604  EDX=0014e600
ESI=00000001  EDI=0014e600  
DS=0053  DSACC=d0f3  DSLIM=3fffffff  
ES=0053  ESACC=d0f3  ESLIM=3fffffff  
FS=150b  FSACC=00f3  FSLIM=00000030
GS=08b3  GSACC=10f3  GSLIM=00003fff
CS:EIP=005b:1def5d25  CSACC=d0df  CSLIM=3fffffff
SS:ESP=0053:0014e5b4  SSACC=d0f3  SSLIM=3fffffff
EBP=0014e6ac  FLG=00012212

NECKO.DLL 0001:00005d25

Comment 7

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 128717 [details] [diff] [review]
Better fix

sr=me, though you may want to also set the out param to null on the error
return....

Comment 8

[Mike Kaply [:mkaply]]

I checked in this fix, which does fix the problem.

LEaving open because on OS/2 there is a bigger issue - why does the unicode
conversion fail in such a strange way?

Comment 9

[Mike Kaply [:mkaply]]

Put in 1.4 as well.

Comment 10

[Mike Kaply [:mkaply]]

Attachment: More fix

The previous fix fixed the bad NS_NewLocalFile stuff.

There is a secondary OS/2 bug we need to workaround as well.

Basically the UniUconv APIs require that the output buffer be at least as big
as the input buffer or they fail immediately with an undocumented API.

So rather than always passing in CCHMAXPATH, we pass in the size of inputLen.

Comment 11

[jhp (no longer active)]

Comment on attachment 135932 [details] [diff] [review]
More fix

Add a better explanation to the comments on why resultLen must be greater than
inputLen.  Otherwise, r=

Comment 12

[Mike Kaply [:mkaply]]

Comment on attachment 135932 [details] [diff] [review]
More fix

sr=blizzard (platform specific)
a=mkaply for 1.6b

Comment 13

[Mike Kaply [:mkaply]]

This bug is fully fixed.