214343 - [FIX]Selection missing pieces and does not cancel properly

Status: RESOLVED FIXED

(Core :: DOM: Selection, defect, P1)

Description

[Benjamin Smedberg]

Selection is mostly broken today... I frequently get pieces of a selection
missing; single-clicking doesn't cancel a selection, etc.

This is a recent regression, works 2003072813 and doesn't work 2003072914.

The checkin I'm fingering is 

07/28/2003 13:45	bzbarsky%mit.edu 	mozilla/ layout/ html/ base/ src/
nsTextFrame.cpp 	1.431 	  	2/5  	Tabbing through textfields should repaint
instead of leaving them looking
selected. Bug 214115, r=brade, sr=dbaron

I'll back this out in my local tree tonight, if someone else doesn't get to it
sooner.

Comment 1

[Simon Montagu :smontagu]

Backing out bug 214115 does not seem to affect the bug.

Here are some more detailed steps to reproduce: In the previous comment, click
in the word "selected" just before the link to Bug 214115, and drag through the
link to "r=brade". 

While the mouse is over the link, there are two selected areas: from the
beginning of the comment to the place where you clicked and from the mouse
location to the end of the link.

Once the mouse is past the link, the link itself is not selected but the text
before and after it are.

Comment 2

[Boris Zbarsky [:bzbarsky]]

Attachment: patch

The blame is me, just for my other checkin.  ;)

Comment 3

[Simon Montagu :smontagu]

Comment on attachment 128820 [details] [diff] [review]
patch

Yes, this fixes the problems I was seeing.

Comment 4

[Christopher Aillon (sabbatical, not receiving bugmail)]

Comment on attachment 128820 [details] [diff] [review]
patch

:-)

Comment 5

[Boris Zbarsky [:bzbarsky]]

*** Bug 214363 has been marked as a duplicate of this bug. ***

Comment 6

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 128820 [details] [diff] [review]
patch

jst, could you please sr?  Just fixing a screw-up from the deCOM patch....

Comment 7

[Johnny Stenback (:jst)]

Comment on attachment 128820 [details] [diff] [review]
patch

sr=jst

Comment 8

[Boris Zbarsky [:bzbarsky]]

Fixed

Comment 9

[Oleg Sidletskiy]

*** Bug 214560 has been marked as a duplicate of this bug. ***