Closed
Bug 214398
Opened 22 years ago
Closed 22 years ago
Refactor some copied code into a function in nsXMLHttpRequest
Categories
(Core :: XML, enhancement)
Core
XML
Tracking
()
RESOLVED
FIXED
People
(Reporter: timwatt, Assigned: hjtoi-bugzilla)
Details
Attachments
(1 file)
|
2.53 KB,
patch
|
jst
:
review+
jst
:
superreview+
|
Details | Diff | Splinter Review |
This is a trivial patch that adds GetDocumentFromScriptContext to contain some
code that gets an nsIDocument from an nsIScriptContext, in nsXMLHttpRequest.cpp.
The code currently exists twice (identically) in the file.
I mimicked the existing functionality as closely as I could (I don't know this
code well enough to make functional changes).
Attachment #128833 -
Flags: superreview?(bz-vacation)
Attachment #128833 -
Flags: review?(jst)
|
||
Comment 2•22 years ago
|
||
Comment on attachment 128833 [details] [diff] [review]
Add GetDocumentFromScriptContext
r+sr=jst given that this is just moving code around.
Attachment #128833 -
Flags: superreview?(bz-vacation)
Attachment #128833 -
Flags: superreview+
Attachment #128833 -
Flags: review?(jst)
Attachment #128833 -
Flags: review+
checked in by timeless: 07/29/2003 23:57
Status: NEW → RESOLVED
Closed: 22 years ago
Resolution: --- → FIXED
This probably caused bug 239572, remember that do_QueryInterface is nullsafe
whereas CallQueryInterface isn't.
You need to log in
before you can comment on or make changes to this bug.
Description
•