214447 - Shorten attribute and method names in nsIAccessible

Status: RESOLVED FIXED

(Core :: Disability Access APIs, defect)

Description

[Aaron Leventhal]

A lot of names in nsIAccessible have "acc" in them, e.g.:
GetAccFirstChild(), AccGetBounds(), GetAccActionName()

This bugs is to get rid of the "acc" - it's redundant since we're already using
nsIAccessible, e.g.:
GetFirstChild(), GetBounds(), GetActionName()

Comment 1

[Aaron Leventhal]

Attachment: Remove "acc" from attrib and method names in nsIAccessible

Comment 2

[Alec Flett]

Comment on attachment 128854 [details] [diff] [review]
Remove "acc" from attrib and method names in nsIAccessible

looks great!

the "getFromXXX" method names are a bit odd to me - maybe you want
getLeftNode() or something? I think its "get from" that bothers me... anyhow,
sr=alecf on this because its good stuff, but if you want to change those
methods too, the sr= still applies.

Comment 3

[Aaron Leventhal]

Okay, I'm going to put up a new patch though.

I found a problem when compiling under Linux:

nsIAccessible::GetParent, GetPreviousSibling, GetNextSibling, GetFirstChild,
GetLastChild all now conflict with the same method names in nsIAccessNode.

See,
nsAccessible inherits from nsAccessNode and implements both nsIAccessible and
nsIAccessNode.

Therefore, the method names need to be different -- they navigate relatived to
the accessible tree or the access node tree.

The architecture is documented here:
http://www.mozilla.org/projects/ui/accessibility/accessible-architecture.html

Comment 4

[Aaron Leventhal]

Alec, wouldn't GetAccessibleFrom[Left/Right/Above/Below]() be better?

I'm concerned that if we use the term node people might forget that we're not
talking about DOM nodes.
Also, that way we we wouldn't end up with GetAboveNode(), which sounds strange
to me.

Comment 5

[Alec Flett]

node/accessible/whatever, just as long as it isn't "acc" :)

My big issue with the word "accessible" is that its an adjective, not a noun..
but I guess that's maybe something for a different rewrite of these interfaces :)

Comment 6

[Aaron Leventhal]

Alec, The term "accessible" has historically been used as a noun in
accessibility interfaces.

Comment 7

[Aaron Leventhal]

Attachment: Fixes alecf and gcc's issues

Comment 8

[Aaron Leventhal]

Attachment: Hmm, last patch was corrupted

Comment 9

[Aaron Leventhal]

Attachment: Fixes last GCC warnings

Comment 10

[Aaron Leventhal]

Comment on attachment 128887 [details] [diff] [review]
Fixes last GCC warnings

Carried sr=alecf

Comment 11

[Kyle Yuan]

Comment on attachment 128887 [details] [diff] [review]
Fixes last GCC warnings

I like the new name - less is more.
r=kyle

Comment 12

[Aaron Leventhal]

thanks everyone. checked in.