Closed
Bug 214487
Opened 22 years ago
Closed 22 years ago
[FIX]Parsing border-side shorthands messes up with colors
Categories
(Core :: CSS Parsing and Computation, defect, P2)
Core
CSS Parsing and Computation
Tracking
()
RESOLVED
FIXED
mozilla1.5beta
People
(Reporter: bzbarsky, Assigned: bzbarsky)
References
()
Details
Attachments
(1 file, 1 obsolete file)
|
6.94 KB,
patch
|
dbaron
:
review+
dbaron
:
superreview+
|
Details | Diff | Splinter Review |
The basic issue is that leaving a color out of a
border-top/border-left/border-right/border-bottom shorthand sets the color to
empty instead of NS_STYLE_COLOR_MOZ_USE_TEXT_COLOR.
The border shorthand gets this right.
|
Assignee | |
Updated•22 years ago
|
Priority: -- → P2
Target Milestone: --- → mozilla1.5beta
|
|
Assignee | |
Comment 1•22 years ago
|
||
|
|
Assignee | |
Comment 2•22 years ago
|
||
Comment on attachment 128863 [details] [diff] [review]
patch
David, would you review? Pretty simple change...
Attachment #128863 -
Flags: superreview?(dbaron)
Attachment #128863 -
Flags: review?(dbaron)
Comment on attachment 128863 [details] [diff] [review]
patch
Why aren't we using the same code for parsing 'border' and 'border-left' etc.?
Attachment #128863 -
Flags: superreview?(dbaron)
Attachment #128863 -
Flags: superreview+
Attachment #128863 -
Flags: review?(dbaron)
Attachment #128863 -
Flags: review+
|
|
Assignee | |
Comment 4•22 years ago
|
||
Attachment #128863 -
Attachment is obsolete: true
|
|
Assignee | |
Updated•22 years ago
|
Attachment #128898 -
Flags: superreview?(dbaron)
Attachment #128898 -
Flags: review?(dbaron)
Attachment #128898 -
Flags: superreview?(dbaron)
Attachment #128898 -
Flags: superreview+
Attachment #128898 -
Flags: review?(dbaron)
Attachment #128898 -
Flags: review+
|
|
Assignee | |
Comment 5•22 years ago
|
||
Checked that second patch in.
|
|
Assignee | |
Comment 6•22 years ago
|
||
.
Status: NEW → RESOLVED
Closed: 22 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•