Closed
Bug 214497
Opened 21 years ago
Closed 21 years ago
Unused variable initMovieCount in nsSound.cpp
Categories
(Core Graveyard :: GFX: Mac, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: timeless, Assigned: timeless)
Details
Attachments
(1 file)
|
595 bytes,
patch
|
mozeditor
:
review+
tor
:
superreview+
|
Details | Diff | Splinter Review |
/Users/timeless/mozilla/widget/src/mac/nsSound.cpp: In member function `OSErr nsMovieSoundRequest::TaskActiveMovies(PRBool*)': /Users/timeless/mozilla/widget/src/mac/nsSound.cpp:1064: warning: unused variable `PRInt32 initMovieCount'
|
||
Comment 1•21 years ago
|
||
I assume that you are compiling Phoenix.
This patch fixes the warning, but it is a surprise to me that the
count of movies is not needed ...
Index: widget/src/mac/nsSound.cpp
===================================================================
RCS file: /cvsroot/mozilla/widget/src/mac/nsSound.cpp,v
retrieving revision 1.35
diff -r1.35 nsSound.cpp
1064c1064
< PRInt32 initMovieCount = mMovies.Count();
---
> // PRInt32 initMovieCount = mMovies.Count();
i'm building seamonkey (for this bug). you can see from later in the function that we just call the count method for each iteration of the loop.
Attachment #128954 -
Flags: superreview?(kin)
Attachment #128954 -
Flags: review?(mozeditor)
|
||
Updated•21 years ago
|
Attachment #128954 -
Flags: review?(mozeditor) → review+
Comment on attachment 128954 [details] [diff] [review] remove the line sr=tor
Attachment #128954 -
Flags: superreview?(kin) → superreview+
checked in
Status: NEW → RESOLVED
Closed: 21 years ago
Resolution: --- → FIXED
|
||
Updated•16 years ago
|
Product: Core → Core Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•