214497 - Unused variable initMovieCount in nsSound.cpp

Status: RESOLVED FIXED

(Core Graveyard :: GFX: Mac, defect)

Description

[timeless]

/Users/timeless/mozilla/widget/src/mac/nsSound.cpp: In member function `OSErr
   nsMovieSoundRequest::TaskActiveMovies(PRBool*)':
/Users/timeless/mozilla/widget/src/mac/nsSound.cpp:1064: warning: unused
   variable `PRInt32 initMovieCount'

Comment 1

[Ben Fowler]

I assume that you are compiling Phoenix.

This patch fixes the warning, but it is a surprise to me that the
count of movies is not needed ...

Index: widget/src/mac/nsSound.cpp
===================================================================
RCS file: /cvsroot/mozilla/widget/src/mac/nsSound.cpp,v
retrieving revision 1.35
diff -r1.35 nsSound.cpp
1064c1064
<   PRInt32 initMovieCount = mMovies.Count();
---
> //  PRInt32 initMovieCount = mMovies.Count();

Comment 2

[timeless]

Attachment: remove the line

i'm building seamonkey (for this bug). you can see from later in the function
that we just call the count method for each iteration of the loop.

Comment 3

[tor]

Comment on attachment 128954 [details] [diff] [review]
remove the line

sr=tor

Comment 4

[timeless]

checked in