Closed Bug 214577 Opened 21 years ago Closed 21 years ago

[FIX]most of the page is black

Categories

(Core :: DOM: HTML Parser, defect)

Product:
Core
Component:
DOM: HTML Parser
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED

People

(Reporter: pavel1r, Assigned: bzbarsky)

References

(
URL
)

Details

(Keywords: regression)

Attachments

(2 files)

screenshot of www.cygwin.com
47.89 KB, image/jpeg
Details
patch
4.27 KB, patch
peterv
: review+
peterv
: superreview+
Details | Diff | Splinter Review 
User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.5b) Gecko/20030730
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.5b) Gecko/20030730

On www.cygwin.com most of the page displayed as black - no text can be seen.

Reproducible: Always

Steps to Reproduce:
1. Load www.cygwin.com
2.
3.

Actual Results:  
Page is black and no text.

Expected Results:  
Display page with white background.

    
    

    
  
The page has two <body> tags; the second of these is:

<body bgcolor="#000000" color="#000000" link="#000000" vlink="#000000"
alink="#000000">

That sure looks like black on black to me...

Now we have code in the content sink that will take all the attributes from all
<body> tags in the document and set them on the first <body>; apparently some
pages rely on this behavior...
Assignee: general → english-us
Status: UNCONFIRMED → NEW
Component: Browser-General → English US
Ever confirmed: true
Product: Browser → Tech Evangelism
QA Contact: general → english-us
Version: Trunk → unspecified

    
    

    
  
This page looks find in Mozilla 1.4/Netscape 7.1 though.

    
    

    
  
Actually, this is a regression.
Assignee: english-us → harishd
Component: English US → Parser
Keywords: regression
OS: Windows 2000 → All
Product: Tech Evangelism → Browser
QA Contact: english-us → dsirnapalli
Hardware: PC → All
Version: unspecified → Trunk

    
    

    
  

      
      
      
      

        Attached patch
          
          
        patch
        — 
          — Splinter Review
      

    


  

    
  

        Attachment #128929 -
        Flags: superreview?(jst)

        Attachment #128929 -
        Flags: review?(jst)

    
    

    
  
caillon, looks like I semi-lied.  Could you drive this in for 1.5b, please?  The
idea here is that when setting attributes on the three nodes that we special
case by not creating multiple copies of them ever (html, head, body) we don't
want to clobber existing attrs...  I broke this when I changed AddAttributes to
not check HasAttr and to loop in the reverse direction instead.

        Attachment #128929 -
        Flags: superreview?(jst)

        Attachment #128929 -
        Flags: superreview+

        Attachment #128929 -
        Flags: review?(jst)

        Attachment #128929 -
        Flags: review+

    
    

    
  
Taking...
Assignee: harishd → bz-vacation
Summary: most of the page is black → [FIX]most of the page is black

    
    

    
  
Fixed.
Status: NEW → RESOLVED
Closed: 21 years ago
Resolution: --- → FIXED

    
    

    
  
*** Bug 214749 has been marked as a duplicate of this bug. ***

    
    

    
  
Test checked in as part of test for bug 324378
Flags: in-testsuite+

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: