214832 - document title changes to/bookmarks as [object HTMLImageElement]

Status: RESOLVED FIXED

(SeaMonkey :: Bookmarks & History, defect)

Description

[Michael Newton]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.5a) Gecko/20030728 Mozilla Firebird/0.6.1
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.5a) Gecko/20030728 Mozilla Firebird/0.6.1

If I go to the specified page and try to bookmark it, the bookmark comes up with
the title [object HTMLImageElement] for the page.  Furthermore, if I make a new
tab, and then return to the original tab, the text on the window title bar
changes to [object HTMLImageElement] as well.
I filed this under Firebird cause it looks like it would be an XUL problem, and
I don't have a Mozilla installation.  Please change it if necessary.

Reproducible: Always

Steps to Reproduce:
1. Go to the site
2. Bookmark the page
3. Observe the title

Actual Results:  
Should say "Jobs Workers Training and Careers"

Expected Results:  
Says "[object HTMLImageElement]"

I am running a fresh install, and a new profile.

Comment 1

[Michael Newton]

I should add that it doesn't affect the site's tab title text, even if other
tabs are closed and then reopened (thereby refreshing this site's tab title.)

Comment 2

[Bill Mason]

Not entirely Firebird specific.  Can also see the bookmark problem in 2003072909
PC/WinXP.  

The tabbed behavior problem is Firebird specific.  Reproduced in 20030729
PC/WinXP but not in Mozilla of same date.

->Browser/Bookmarks first, I guess.  Someone can correct if necessary.

Comment 3

[Boris Zbarsky [:bzbarsky]]

The bookmarks code needs to use the safe property accessor; just using
document.title is incorrect.

Comment 4

[Jesse Ruderman]

*** Bug 215929 has been marked as a duplicate of this bug. ***

Comment 5

[[e-mail]]

Attachment: Fix for adding bookmarks

Comment 6

[[e-mail]]

Attachment: Alternative approach

Comment 7

[Christopher Aillon (sabbatical, not receiving bugmail)]

Comment on attachment 131769 [details] [diff] [review]
Alternative approach

r=caillon for this approach.

Comment 8

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 131769 [details] [diff] [review]
Alternative approach

sr=bzbarsky.  Neat.

Comment 9

[[e-mail]]

Fix checked in.

Comment 10

[John Mertic]

Attachment: Screenshot of bug still being present

It still is happenin for me with the 9/25 build

Comment 11

[Boris Zbarsky [:bzbarsky]]

This bug was about bookmarks.  The code that handles setting the titlebar for
the window is in a different place and needs a separate bug.

Comment 12

[John Mertic]

Bug 215929 is that bug. It was marked as a duplicate of this one. It should be
reopened.

Comment 13

[Masato Ikeda]

This bug is still present with Firefox:
Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.7.5) Gecko/20041107 Firefox/1.0
and
Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.8a6) Gecko/20041204
Firefox/1.0+ .

Not present with Suite:
Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.8a6) Gecko/20041204 .

Should this be reopend for Firefox?

Comment 14

[Christian :Biesinger (don't email me, ping me on IRC)]

(In reply to comment #13)
> Should this be reopend for Firefox?

no, please file a new bug for ffox

Comment 15

[Boris Zbarsky [:bzbarsky]]

And make sure to point to this bug in the new bug... (and to file the new bug on
the Firefox product).

Comment 16

[Masato Ikeda]

I opened Bug 273249.