214956 - too long underline in a button i XUL

Status: RESOLVED FIXED

(Core :: XUL, defect)

Description

[Per Persson]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.5a) Gecko/20030728 Mozilla Firebird/0.6.1
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.5a) Gecko/20030728 Mozilla Firebird/0.6.1

The underline on a button's label becomes far too long and leaves the button.
Too see what I mean, try the following XUL document:

<?xml version="1.0"?> 
<window xmlns="http://www.mozilla.org/keymaster/gatekeeper/there.is.only.xul">
  <box flex="0">
    <button label="abc" style="text-decoration: underline;"/>
  </box>
</window>


Reproducible: Always

Steps to Reproduce:
1.
2.
3.

Comment 1

[Kim]

wfm using Mozilla/5.0 (Windows; U; Win98; en-US; rv:1.5b) Gecko/20030808 Mozilla
Firebird/0.6.1+

There doesn't seem to be any delay. This doesn't seem to be a firebird bug
specifically, but I'm not sure which component to move it too.

Comment 2

[Simon Paquet [:sipaq]]

Over to Browser. I'm seeing this too on 2003-09-11 firebird and semonkey builds
on WinXP.

Comment 3

[Neil Deakin]

Attachment: Fixes long underlines on elements

Not sure who reviews XUL patches these days...

Comment 4

[Brendan Eich [:brendan]]

Comment on attachment 134795 [details] [diff] [review]
Fixes long underlines on elements

Either bryner or dbaron could r+sr= this.

/be

Comment 5

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Attachment: reporter's testcase

Comment 6

[Brendan Eich [:brendan]]

Thanks, checked in.

/be

Comment 7

[[e-mail]]

Bah, the so-called XUL document in comment #0 has no stylesheet :-/