Closed
Bug 214968
Opened 22 years ago
Closed 21 years ago
.bmp extension should be listed in Open File options
Categories
(Firefox :: General, enhancement)
Tracking
()
RESOLVED
FIXED
Firefox1.0beta
People
(Reporter: philip, Assigned: ali)
Details
(Keywords: fixed-aviary1.0)
Attachments
(1 file)
714 bytes,
patch
|
mconnor
:
review+
asa
:
approval-aviary+
|
Details | Diff | Splinter Review |
Since Firebird is capable of opening bitmap files, the .bmp extension should be
included in the "Image Files" option of the Open File dialog.
Updated•21 years ago
|
QA Contact: asa
Assignee | ||
Updated•21 years ago
|
Assignee: firefox → bmo
Assignee | ||
Updated•21 years ago
|
Status: NEW → ASSIGNED
Target Milestone: --- → Firefox1.0beta
Assignee | ||
Comment 1•21 years ago
|
||
Assignee | ||
Updated•21 years ago
|
Attachment #153589 -
Flags: review?(mconnor)
Reporter | ||
Comment 2•21 years ago
|
||
Is making this extension available sufficient for Mozilla to actually convert
the image to bitmap, instead of just renaming the extension?
Assignee | ||
Comment 3•21 years ago
|
||
Firefox doesn't convert anything, the image is already in bitmap (bmp) format.
This patch merely adds *.bmp to the list of files that Firefox thinks it can
open as an image in the filepicker.
Reporter | ||
Comment 4•21 years ago
|
||
Oh, sorry, I thought this is a different bug. (I think I also filed one to
allow Mozilla/Firefox to SAVE images as bitmaps.)
Updated•21 years ago
|
Attachment #153589 -
Flags: review?(mconnor) → review+
Comment 5•21 years ago
|
||
Another not-blocker with a patch that if we do want for 1.0, we need to land
before the PR. Blake or Ben, is this desirable?
Flags: blocking-aviary1.0PR?
Comment 6•21 years ago
|
||
bienvenu will try and catch this for 1.0 final
Flags: blocking-aviary1.0PR?
Flags: blocking-aviary1.0PR-
Flags: blocking-aviary1.0+
Updated•21 years ago
|
Attachment #153589 -
Flags: approval-aviary?
Comment 7•21 years ago
|
||
Comment on attachment 153589 [details] [diff] [review]
Add *.bmp to imageFilter
a=asa for aviary checkin.
Attachment #153589 -
Flags: approval-aviary? → approval-aviary+
Comment 8•21 years ago
|
||
checked in br & trunk 08/03/2004 07:13.
Comment 9•21 years ago
|
||
How about updating these three lines too:
http://lxr.mozilla.org/aviarybranch/source/toolkit/locales/sl-SI/chrome/global/filepicker.properties#12
http://lxr.mozilla.org/aviarybranch/source/toolkit/locales/nb-NO/chrome/global/filepicker.properties#12
http://lxr.mozilla.org/aviarybranch/source/xpfe/components/filepicker/res/locale/en-US/filepicker.properties#10
And what about fixing this for seamonkey? I can do that, but would a separate
patch be better for that?
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Comment 10•21 years ago
|
||
err, separate bug
Comment 11•21 years ago
|
||
And how about adding *.xbm and *.ico while you're at it since mozilla supports
them too?
Comment 12•21 years ago
|
||
Closing again at the request of aebrahim. I have filed bug 254381 instead.
Status: REOPENED → RESOLVED
Closed: 21 years ago → 21 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•