214992 - sync Firebird's Page Info with Mozilla's

Status: RESOLVED FIXED

(Firefox :: Page Info Window, defect)

Description

[Daniel Brooks [:db48x]]

A couple of things got checked in to Mozilla's copy but not Firebird's.

Comment 1

[Daniel Brooks [:db48x]]

Attachment: changes everything but the license block

Comment 2

[Daniel Brooks [:db48x]]

Attachment: patch without the progress meter

at pch's request

Comment 3

[Daniel Brooks [:db48x]]

oh, it should be noted that I didn't actually test that, since I couldn't get
firebird to build correctly. It's not like there's much that can go wrong though.

Comment 4

[Daniel Brooks [:db48x]]

fix checked in

Comment 5

[Jon Henry]

There seems to be a problem with this patch. Trying to bring up Page Info in
Firebird now gives an XML error on line 197 of pageInfo.xul. Specifically,
there's a typo in that label="&linkAccesskey;" should be
label="&linksAccesskey;" (note the plural "links"). It's not clear to me the
purpose of this column in the first place, however, as I don't have SeaMonkey
installed to compare to.

Comment 6

[Daniel Brooks [:db48x]]

doh, I forgot a file :P. Thanks for catching that.

Comment 7

[Daniel Brooks [:db48x]]

Attachment: missing hunk

it also seems that this set of changes got lost somewhere. The first hunk of
the patch is something Ben seems to have missed, and the second hunk removes
mention of the entities that had been removed from the dtd (because access keys
haven't really worked right)

Comment 8

[Jesse Ruderman]

Trunk users have been reporting XML errors in Page Info for a few days.  Are
there still files missing?

Comment 9

[Daniel Brooks [:db48x]]

I checked it in. I need page info to work tommorrow.

Comment 10

[Daniel Brooks [:db48x]]

Jesse: Yea, that was me. It's fixed now though. Were there any bugs filed? I
didn't see any.

Comment 11

[Jesse Ruderman]

I don't think any bugs were filed.

Comment 12

[Pierre Chanial]

Comment on attachment 137939 [details] [diff] [review]
missing hunk

what's the status of this patch? and impact?

Comment 13

[Daniel Brooks [:db48x]]

I'd just forgotten it.