215041 - Add support for WinIE's _main target for sidebars (in addition to _content)

Status: RESOLVED FIXED

(Core :: DOM: Navigation, defect)

Description

[David Hyatt]

WinIE supports the _main target.  Currently our target is called _content.  This patch adds support 
for _main, so that we have WinIE compatibility with all of their Explorer Bars in both SeaMonkey 
and Firebird.

Comment 1

[David Hyatt]

Attachment: Add support for _main

Comment 2

[Ben Goodger (use ben at mozilla dot org for email)]

Comment on attachment 129165 [details] [diff] [review]
Add support for _main

sr=[e-mail]

Comment 3

[Hixie (not reading bugmail)]

Comment on attachment 129165 [details] [diff] [review]
Add support for _main

It's ridiculous that we have to check this in five separate places in three
separate files, but whatever. r=hixie.

Comment 4

[David Hyatt]

Initial patch landed.  Still doesn't work though.  I must have missed a spot. 
I'll keep looking.

Comment 5

[David Hyatt]

Attachment: Patch a couple of other places.

This patch gets the one I missed.  The Google IE sidebar works in Firebird or
Seamonkey now with this patch.

Comment 6

[Ben Goodger (use ben at mozilla dot org for email)]

Comment on attachment 129168 [details] [diff] [review]
Patch a couple of other places.

sr=[e-mail]

Comment 7

[Brendan Eich [:brendan]]

Yeah, Hixie's right -- why are these special cases smeared all over the tree?

/be

Comment 8

[Brendan Eich [:brendan]]

Comment on attachment 129168 [details] [diff] [review]
Patch a couple of other places.

All I ask is that danm have a chance to comment, even if you go fast and stuff.

I'll file a followup bug to consolidate the special case code.

/be

Comment 9

[Dan M]

Yay, more reserved property names. Don't you have to worry about making _main
replaceable like the other similar window properties?

Comment 10

[David Hyatt]

Fixed.

Comment 11

[David Hyatt]

This is just for targeting.  There is no window._main like there is a
window._content, so I don't think that's an issue.

Comment 12

[David Hyatt]

Actually, I could be wrong about this.  Let me write some WinIE tests.  If they
support window._main, then you're right.

Comment 13

[David Hyatt]

Yes, window._main is not defined in WinIE.  It's just a target, not a property.
We match their behavior. 

Comment 14

[Mats Palmgren (inactive)]

FYI, this caused bug 217886