215042 - [FIX]frame source is not shown

Status: VERIFIED FIXED

(Core :: Layout: Images, Video, and HTML Frames, defect, P2)

Description

[Haubi]

User-Agent:       Mozilla/5.0 (Windows; U; Win98; en-US; rv:1.5a) Gecko/20030728 Mozilla Firebird/0.6.1
Build Identifier: Mozilla/5.0 (Windows; U; Win98; en-US; rv:1.5a) Gecko/20030728 Mozilla Firebird/0.6.1

Firebird shows nothing. With IE pics and text are shown correctly. What is the
matter?

Reproducible: Always

Steps to Reproduce:
1.
2.
3.

Comment 1

[Simon Paquet [:sipaq]]

Johannes, your "bug report" is seriously lacking information.
What is not shown? What did you do? Did you make a clean install as described in
http://firebird.bric.de/index.php?page=bugs

Comment 2

[Rok Kralj]

I think what the reporter means is theat when you try to open the
http://www.aaleninfo.de url, you get a blank page. Except the page is not blank,
the source shows that the page is there but the frame won't open
(http://213.198.63.12/ajz/index.php <-- frame url).

The bug can also be reproduced on mozilla, just go to the above url...

Comment 3

[Simon Paquet [:sipaq]]

Ok, I see this too.
Moving over to Browser product.

Comment 4

[Boris Zbarsky [:bzbarsky]]

The frame will not load in NS4 either.  More to the point, it loads just fine in
my tip debug build.  It does _NOT_ load in a build from 7/27 (which is about
when the build in comment 0 is).  But a fix for some issues that could cause
that behavior has landed since then; please retest with a current tip build.

Comment 5

[Boris Zbarsky [:bzbarsky]]

OK, the frame itself loads fine in a current build.  The frameset is declared as:

<frameset rows="0" frameborder="0" border="0" framespacing="0">  
<frame src="http://213.198.63.12/ajz/index.php" name="mainFrame">
</frameset>

Which says "make the frame 0px tall". Which is what we do.  IE apparently fails
to work properly in this case.

Over to Tech Evangelism.

Comment 6

[Simon Paquet [:sipaq]]

Re-assigning to Boris, this is a layout issue as well

Comment 7

[Boris Zbarsky [:bzbarsky]]

Attachment: patch

We're all suprised this divide-by-zero didn't crash...

Comment 8

[Boris Zbarsky [:bzbarsky]]

Attachment: Same as diff -w

Comment 9

[Boris Zbarsky [:bzbarsky]]

I won't be able to drive this in for 1.5, probably, so if people want it for
then someone needs to ask for approval and find people to check this in once it
has reviews...

Comment 10

[Boris Zbarsky [:bzbarsky]]

To caillon, since he's volunteered to drive this in...

Comment 11

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Comment on attachment 129562 [details] [diff] [review]
patch

looks good

Comment 12

[Christopher Aillon (sabbatical, not receiving bugmail)]

Back to patch author...

Comment 13

[Christopher Aillon (sabbatical, not receiving bugmail)]

Fix checked in 09/13/2003 12:42.

Comment 14

[Simon Paquet [:sipaq]]

verifying with self-compiled firebird build (checkout date 00:49 CEST 2003-09-14).