215117 - SetRootContent handling in nsXMLContentSink is rotten

Status: RESOLVED FIXED

(Core :: XSLT, defect)

Description

[Axel Hecht]

There are quite a few special quirks in nsXMLContentSink.cpp when setting the
root content of the nsXMLDocument.
AFAICT, those are from back in the days when XSLT transformed into that same
document. Now, that we don't do things like that anymore, we should set the
root content allright.
The root of evil seems to be
http://bonsai.mozilla.org/cvsblame.cgi?file=mozilla/content/xml/document/src/nsXMLContentSink.cpp&rev=HEAD&root=/cvsroot&mark=1752#1749

This stuff not only smells funny, but horks document order or top level comments
and PIs with respect to other nodes, ie the document element is hardcoded to
be the last child.

Comment 1

[Peter Van der Beken [:peterv]]

Attachment: One SetRootContent call should be enough

Comment 2

[Axel Hecht]

Comment on attachment 129224 [details] [diff] [review]
One SetRootContent call should be enough

that's what I thought.

Comment 3

[Johnny Stenback (:jst)]

Comment on attachment 129224 [details] [diff] [review]
One SetRootContent call should be enough

sr=jst

Comment 4

[Peter Van der Beken [:peterv]]

Checked in.