215159 - nsViewManager::CreateDisplayList leaks hash keys

Status: RESOLVED FIXED

(Core :: Web Painting, defect)

Description

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Loading http://www.w3.org/Style/CSS/ I noticed that
nsViewManager::CreateDisplayList leaks hash keys.  The following line is
misusing the nsHashtable API:

mMapPlaceholderViewToZTreeNode.Put(new nsVoidKey(aView), aResult);

nsHashtable::Put clones the key (and if it weren't deprecated we probably ought
to make it take a |const nsHashKey&|.  The code you really want is:

nsVoidKey key(aView);
mMapPlaceholdeViewToZTreeNode.Put(&key, aResult);

Comment 1

[Robert O'Callahan (:roc) (email my personal email if necessary)]

oops!

Comment 2

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Attachment: fix

obvious patch

Comment 3

[Hermann Schwab]

Isn´t this fixed?
http://bonsai.mozilla.org/cvslog.cgi?file=mozilla/view/src/nsViewManager.cpp
3.300	roc+%cs.cmu.edu	Aug 12 08:56	 	Bug 213303. Allow events to be sent to
views which are totally clipped out. r+sr=dbaron,a=brendan. Patch by
[e-mail].
3.299	roc+%cs.cmu.edu	Aug 5 18:42	 	Bug 215159. Fix memory leak in
nsViewManager. r+sr=dbaron

Version 3.300 doesn´t fix Bug 213303, must be a typo, as that bug is invalid.

Comment 4

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Yeah, I checked this in and forgot to mark FIXED.