215220 - Unable to receive caret-move event in HTML document

Status: RESOLVED FIXED

(Core :: Disability Access APIs, defect)

Description

[Kyle Yuan]

The problem is in nsCaretAccessible::AttachNewSelectionListener(), we get 
presShell from GetPresShell(), get doc from presShell->GetDocument, unlike the 
version before 1.12 in which we get doc from aCurrentNode->GetOwnerDocument and 
get presShell from doc->GetShellAt(0,..), so we keep getting the nsXULDocument 
but never nsHTMLDocument.

Comment 1

[Kyle Yuan]

Aaron, I think the code in nsCaretAccessible::AttachNewSelectionListener() 
could be wrong, because we only have one nsCaretAccessible object, which is 
created at the same time with nsRootAccessible's creation and using the xul 
document's presshell, but we need the caret listener can be tied to all kind of 
document, so we should get the document from the current focused node instead 
of the presshell (like what we did before). What do you think?

Comment 2

[Kyle Yuan]

Attachment: getting PresShell from nsRootAccessible::GetEventShell instead of mWeakShell

Comment 3

[Aaron Leventhal]

Comment on attachment 129707 [details] [diff] [review]
getting PresShell from nsRootAccessible::GetEventShell instead of mWeakShell

r=aaronl

Comment 4

[Kyle Yuan]

taking...
Henry, may I get sr= from you?

Comment 5

[Henry Jia]

Comment on attachment 129707 [details] [diff] [review]
getting PresShell from nsRootAccessible::GetEventShell instead of mWeakShell

seems ok.

Comment 6

[Kyle Yuan]

checked in.