Closed Bug 215384 Opened 22 years ago Closed 22 years ago

"Group by date" often sorts incorrectly

Categories

(Firefox :: Bookmarks & History, defect)

defect
Not set
normal

Tracking

()

VERIFIED FIXED

People

(Reporter: bryner, Assigned: bryner)

Details

Attachments

(1 file)

If you select a grouping other than "by date" in the history sidebar, then switch back to group by date, the folders become sorted alphabetically, i.e. 2 days ago 3 days ago Today Yesterday instead of chronologically: Today Yesterday 2 days ago 3 days ago
-> me
Assignee: blake → bryner
Attached patch patchSplinter Review
My attempt at fixing the problem... this adds a new property for the day folders which gives the index (0-7) to be used for sorting. In addition, I removed the hidden columns from the tree and instead just change the "sort" attribute on the name column to the property to sort on (per conversation with waterson, the template code currently requires the sort key to be part of the template, which is why I made all of the possible sort keys be attributes on the treeitems.)
Attachment #129350 - Flags: review?(bugs)
checked in.
Status: NEW → RESOLVED
Closed: 22 years ago
Resolution: --- → FIXED
Verified.
Status: RESOLVED → VERIFIED
Verified.
Component: History → Bookmarks & History
QA Contact: mozilla → bookmarks
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: