Closed Bug 215463 Opened 21 years ago Closed 20 years ago

add ctrl++/ctrl+- to View Source

Categories

(Firefox :: General, enhancement)

Product:
Firefox
Component:
General
Type:
enhancement
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
Firefox0.9

People

(Reporter: alpeterson, Assigned: rjkeller)

Details

Attachments

(1 file, 1 obsolete file)

New Patch
4.51 KB, patch
p_ch
: review+
Details | Diff | Splinter Review 
User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.5b) Gecko/20030726 Mozilla Firebird/0.6.1
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.5b) Gecko/20030726 Mozilla Firebird/0.6.1

I can't change the font preferences in the view -->Page Source window.

I can't read the font it's so small...  control + and control - should be really
easy to implement in this window... it is very important, because the syntax
highlighting is very cool and usefull for debugging.

Reproducible: Always

Steps to Reproduce:
1.look for ways to increase text size in Page Source view..
2.don't see any way, try control + and control -
3.submit bug report

Actual Results:  
nothing

Expected Results:  
font sizes should have changed

This will probably be re ruled a feature request or enhansement... but it's
not... the view page source is unusable for me... and the behavior of control
keys is inconsistant with the rest of the product.
Control +/- WFM 20030807 PC/WinXP
You can go to Options>Web Features>FontsColors>Monospace>Size
and make it bigger than 13.
that will make content/websites that don't have font settings to have bigger fonts

So if you think content in Page Source is too small, then you must think sites
that use that setting also are too small so changing monospace>size won't be a
problem

you can reopen if you want to add the things anyway
Status: UNCONFIRMED → RESOLVED
Closed: 21 years ago
Resolution: --- → INVALID
I'm sorry I just realized that I was using a nightly build on my gentoo... from 
a couple days before .6.1 came out ...  I just rememerged it so I'll see if it 
works... but I'm in windows now...
now I'm using a later build, and have tried it with 0.6.1

Control +  and contro - do nothing when viewing soruce

and there is no font size change tool in the view source window.

as for regular text being small... yes I can barely read this right now, but I'm
not looking for bugs in code... I don't care if I write a semicolon or a colon
or other such things now... and... if I ever need it bigger, I can just hit
control+ or control -  

So changing the default font size in the main browser window is not what I want
to do.
Status: RESOLVED → UNCONFIRMED
Resolution: INVALID → ---
ah, my 0.6.1 was on windowsXP, linux and 0.6.1+ is on Gentoo
If you think this page looks too small then that mus mean you change font sizes
constantly which sounds like a pain and not as easy as changing the default.
not resolving again because you'll reopen, not confirming because I don't agree
Severity: major → enhancement
OS: Linux → All
Hardware: PC → All
Whiteboard: add ctrl++/ctrl+- to View Source
Summary: view page source doesn't have font option control+ control- doesn't work → add ctrl++/ctrl+- to View Source
Whiteboard: add ctrl++/ctrl+- to View Source
Aaron, you can use Ctrl+Scroll to resize, but I agree that Ctrl++ and Ctrl+-
should be supported for text resizing as well.  Confirming for now, but View
Source is bound to be debated with the separation of the developer tools into an
install-time option.
Status: UNCONFIRMED → NEW
Ever confirmed: true
QA Contact: asa → mpconnor
I'll fix this.
--> me
I'm doing this.
Assignee: blake → rlk
Attached patch Patch (obsolete) — — Splinter Review 
Makes Ctrl+ and Ctrl- work.
Attachment #130478 - Flags: review?(blake)
Comment on attachment 130478 [details] [diff] [review]
Patch

Blake is apparently too busy. Let's try hyatt (not sure if he does this kind of
review).
Attachment #130478 - Flags: review?(blake) → review?(hyatt)
Comment on attachment 130478 [details] [diff] [review]
Patch


>+}
>+
>+function getMarkupDocumentViewer()
>+{
>+  return gBrowser.markupDocumentViewer;

this does what in relation to your patch?

>+  <commandset id="viewZoomCommands"/>

what does this add to this patch?

>   <stringbundleset id="viewSource-stringbundleset">
>     <stringbundle id="findBundle" src="chrome://global/locale/finddialog.properties"/>
>+    <stringbundle id="bundle_viewZoom"/>

why do you need a stringBundle if you're not adding UI? also, there's no src
attribute, so its a useless line

There's some other nits which I won't get into.  The definitions for the access
keys, the added .js file and the added keybindings should be all that's in the
patch if you're just looking to add the keybindings without UI (which is about
all that's needed)

Also, hyatt's even less likely to review this patch than blake.  Reviews aren't
the easiest thing to get in Firebird circles.  If there's anything else you
wouldn't mind me taking a look at, let me know.
Attachment #130478 - Flags: review?(hyatt) → review-
Comment on attachment 130478 [details] [diff] [review]
Patch

>this does what in relation to your patch?
It's required by the overlay.

>what does this add to this patch?
The <command>s used in the <key>s.

>why do you need a stringBundle if you're not adding UI? also, there's no src
>attribute, so its a useless line
This is required by the overlay. It won't function without it.
Attachment #130478 - Flags: review- → review?(mpconnor)
Comment on attachment 130478 [details] [diff] [review]
Patch

back to blake, i guess
Attachment #130478 - Flags: review?(mpconnor) → review?(blake)
I remember what I was going to ask you on IRC: add Ctrl+0 if you're going to add
these.
Ctrl+0? I don't think that I'm familiar with that hotkey. What function does it
do? I doesn't seem to be in Seamonkey.
Thanks for that patch to allow control + and control - to work in the view
source window.

I think a proper font dialog would be appropriate....   like KDE has one.. and
Windows has one...    and that is OS dependent   or we could write our own...

anyway... shouldn't the view source window be just a regular browser window with
a "plug-in" type feel?  like how the adobe pdf viewer works?

Does it use gecko to render the source?
or something remenant from the past?
Attachment #130478 - Flags: review?(blake) → review?(bugs)
--> Firebird 0.9

My old patch appears to have bit-rotted. I'll post a new version of the patch
for the latest view source code soon.
Status: NEW → ASSIGNED
Target Milestone: --- → Firebird0.9
rlk, to answer the question I never answered, Ctrl+0 resets to the default font
size.  Try it in a normal browser window to see what I mean.

Also, it would have bitrotted with the numerous changes pch made in the last
month or so.
Attached patch New Patch — — Splinter Review 
The other patch has bit-rotted. This is a new patch that should work with the
latest View Source code.
Attachment #130478 - Attachment is obsolete: true
Attachment #138223 - Flags: review?(p_ch)
Comment on attachment 138223 [details] [diff] [review]
New Patch

r=me given that you also update viewPartialSource.xul
Attachment #138223 - Flags: review?(p_ch) → review+
Also, I think it's better to get rid of getMarkupDocumentViewer() and inline
getBrowser().markupDocumentViewer in viewSource.js. gBrowser is probably
defined,  but it's better not to have to worry about that.
Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7a) Gecko/20040110 Firebird/0.8.0+
(daihard: XFT+GTK2; optimized for P4/SSE-2)

Ctrl-MWHEELUP and Ctrl-MWHEELDOWN work in a View Source window. IMHO this would
be VERIFIED FIXED if others agree.
Sorry for the bugspam, but Ctrl-Plus and Ctrl-Minus are analogous to holding
down Ctrl and rolling the mouse wheel. Either method resizes fonts in a View
Source window.
this hasn't landed yet, and we know Ctrl+Mousewheel works, but Ctrl++ and Ctrl+-
don't work, at least on Windows.  Until that's in place, this isn't fixed.  The
patch hasn't even landed yet afaik...
You're right - Ctrl-Plus and Ctrl-Minus don't work; I was sure that they did.
But Ctrl-MWHEELUP and Ctrl-MHWEELDOWN definitely work, at least on Linux. Sorry
for the bugspam.
(In reply to comment #27)
> You're right - Ctrl-Plus and Ctrl-Minus don't work; I was sure that they did.
> But Ctrl-MWHEELUP and Ctrl-MHWEELDOWN definitely work, at least on Linux. Sorry
> for the bugspam.
I noticed that ctrl++ and ctrl+- dont work yet on firefox 0.8 linux
Fix checked in.

I applied all the changes applied to viewSource.xul to viewPartialSource.xul too
and tested it since the patch is a bit old. Everything seemed to work, so I
checked it in!

Reopen if there are problems.
Status: ASSIGNED → RESOLVED
Closed: 21 years ago → 20 years ago
Resolution: --- → FIXED
Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.7b) Gecko/20040323
Firefox/0.8.0+ (djeter)

Noticed that this doesn't work with the +/= key next to backspace.  I know
that'd mean Ctrl+= but it works in the browser so it should work in view source too.
yeah, we need it to work for that key too :)
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Let's move that to another bug. This bug was about Ctrl+ and Ctrl-. If you want
other keys, file another bug and just assign it to me.

I just checked and Ctrl+ and Ctrl- works on Firefox 20040323 on Windows XP and
Windows 2000, so this bug is done.
Status: REOPENED → RESOLVED
Closed: 20 years ago → 20 years ago
Resolution: --- → FIXED
Bug 238474 was filed for the issue mentioned in comment 30
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: