215473 - Implement tooltips for z-index and layer buttons in Composer.

Status: RESOLVED FIXED

(SeaMonkey :: Composer, defect)

Description

[[e-mail] (gone - use [e-mail] instead)]

We (I?) need to implement tooltips for the 3 elements on the Composer toolbar
that are found to the right of the 'Align Justified' toolbar button.

I've got a preliminary patch, but I don't (yet) know how to actually build those
buttons in a self-build via CVS.

Daniel, can you provide some feedback/assistance?  Thanks.

Patch attached.

Comment 1

[[e-mail] (gone - use [e-mail] instead)]

Attachment: Start of a patch (includes some whitespace cleanup)

Comment 2

[Kathleen :Brade]

-->glazman for comments on patch

Comment 3

[Daniel Glazman (:glazou) (not active in Mozilla any more)]

Comment on attachment 129403 [details] [diff] [review]
Start of a patch (includes some whitespace cleanup)


>@@ -861,9 +862,14 @@
>   
>   <toolbarbutton id="absolutePositionButton" type="checkbox" observes="cmd_absPos">
>     <observes element="cmd_absPos" attribute="state" onbroadcast="onStateButtonUpdate(this.parentNode, 'cmd_absPos', 'absolute')"/>
>+                tooltiptext="&layer.tooltip;"
>+  </toolbarbutton>

This is invalid XML, you forgot to remove the /> before tooltiptext
attribute...

>+  <toolbarbutton id="decreaseZIndexButton" observes="cmd_decreaseZIndex">
>+                tooltiptext="&layerSendToBack.tooltip;"
>+  </toolbarbutton>         

Same thing here for >

>+  <toolbarbutton id="increaseZIndexButton" observes="cmd_increaseZIndex">
>+                tooltiptext="&layerBringToFront.tooltip;"
>   </toolbarbutton>

Same thing here for >

Should be ok otherwise.

Comment 4

[Daniel Glazman (:glazou) (not active in Mozilla any more)]

Comment on attachment 129403 [details] [diff] [review]
Start of a patch (includes some whitespace cleanup)


>   <toolbarbutton id="absolutePositionButton" type="checkbox" observes="cmd_absPos">
>     <observes element="cmd_absPos" attribute="state" onbroadcast="onStateButtonUpdate(this.parentNode, 'cmd_absPos', 'absolute')"/>
>+                tooltiptext="&layer.tooltip;"
>+  </toolbarbutton>

More comment on this one: the tooltiptext attribute should be set on the
toolbarbutton element, not the observes element.

Comment 5

[[e-mail] (gone - use [e-mail] instead)]

Daniel, thanks for the reviews.

Unfortunately, I was never able to see the fruits of my changes (for some
reason, my build never picked up those 3 buttons, so I was doing this blindly
based on past knowledge).

Also, I've since sent my machine back to AOL, so I no longer have a build
environment and have yet to set up mingw.

Can you drive the correct fixes in?  Thanks!

Comment 6

[Daniel Glazman (:glazou) (not active in Mozilla any more)]

Attachment: stephen's patch after cleanup

Here it is

Comment 7

[Daniel Glazman (:glazou) (not active in Mozilla any more)]

Comment on attachment 129511 [details] [diff] [review]
stephen's patch after cleanup

I can review this patch since it really comes from Stephen Donner...

r=glazman

Comment 8

[[e-mail] (gone - use [e-mail] instead)]

Thanks for cleaning up my mess ;-)

Comment 9

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 129511 [details] [diff] [review]
stephen's patch after cleanup

sr=bzbarsky

Comment 10

[[e-mail] (gone - use [e-mail] instead)]

Comment on attachment 129511 [details] [diff] [review]
stephen's patch after cleanup

Requesting a= for a simple patch that allows people to see what these 3 buttons
actually do, using a tooltip.

Comment 11

[Asa Dotzler [:asa]]

Comment on attachment 129511 [details] [diff] [review]
stephen's patch after cleanup

a=asa (on behalf of drivers) for checkin to Mozilla 1.5beta.

Comment 12

[Stephen Donner [:stephend] Not actively reading bugmail]

Daniel, when you get a chance, could you land this for me?  Thanks!

Comment 13

[Stephen Donner [:stephend] Not actively reading bugmail]

Chris, are you available/willing to land my patch? Thanks, either way.

Comment 14

[Christopher Aillon (sabbatical, not receiving bugmail)]

Checked in for stephen.

Comment 15

[Stephen Donner [:stephend] Not actively reading bugmail]

Thanks so much, Chris.

Daniel, sorry if you meant to do this tonight/early morning tomorrow.  I don't
know the official tree closing date ;-(

Comment 16

[Daniel Glazman (:glazou) (not active in Mozilla any more)]

No, problem Stephen... remember I live 9 hours ahead of California.