215656 - Cookie manager window scrollbar resizes incorrectly when cookies are deleted

Status: VERIFIED FIXED

(Core :: Networking: Cookies, defect)

Description

[Faxmaster]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.5b) Gecko/20030808 Mozilla Firebird/0.6.1+
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.5b) Gecko/20030808 Mozilla Firebird/0.6.1+

When a cookie is deleted from the cookie manager, the scrollbar gets
increasingly smaller.  If you delete enough cookies (about five or six), a large
amount of whitespace gets created below the last cookie on the list.

Reproducible: Always

Steps to Reproduce:
1.  Go to Tools | Options
2.  Open the cookie manager.
3.  Delete a cookie and watch the scrollbar shrink in size.

Actual Results:  
The scrollbar gets smaller whenever a cookie is deleted.  Whitespace also
appears underneath the last cookie on the list.

Expected Results:  
The scrollbar should increase in size whenever a cookie is deleted.  Whitespace
should not be created when cookies are deleted.

Comment 1

[Dai Toyama]

Looks to me that when they recalculate the size of the combo box, they add the
new size to the original instead of replacing the original with the new value,
thereby making the combo box about twice as long as it should be.

Comment 2

[Simon Paquet [:sipaq]]

Confirmed with 20030809 build on W2K.

Comment 3

[Vignir G.]

Probably a totally different thing, but the cookie manager doesn´t remember user
selected state of the three columns (SITE, COOKIE NAME, STATUS). It always
defaults to just showing SITE, and COOKIE STATUS the next time it is opened.
This happens in both FB and the Mozilla Suite, so maybe another bug should be
opened for this???

Comment 4

[Rastignac]

This bug was already present in Mozilla suite 1.5a (Windows XP). It is also in
Mozilla suite 1.5b (Windows XP). The 1.4 is safe from this bug.
"OS" and "version" can be updated.

Comment 5

[Scott Gifford]

I see this on Linux too, with FB 20030903.

Comment 6

[Rastignac]

This bug should be changed:
- from "Firebird specific" to "Mozilla general".
- it should be "blocker for 1.5 final".

Thanks.

Comment 7

[Simon Paquet [:sipaq]]

Moving to Browser

Comment 8

[Rastignac]

This bug is still in 1.5rc1 and is still in 1.5rc2.
It should be marked as "1.5 final blocker". We can't ship 1.5 without fixing
this bug... This bug is too visible; users will see it and complain.

Comment 9

[Michiel van Leeuwen (email: mvl+moz@)]

*** Bug 220592 has been marked as a duplicate of this bug. ***

Comment 10

[benc]

"I'm not a pref, I'm a cookie!"

Comment 11

[Rastignac]

"1.5 final release" is now OUT. And this bug is still present... Dooooh. Nobody
cares about this bug. What a pitty.

So, now, what ? Will we see a "1.5.1" with this bug corrected ? Or, will we wait
until 1.6a ?

Comment 12

[[e-mail]]

>So, now, what ? Will we see a "1.5.1" with this bug corrected ? Or, will we wait
>until 1.6a ?

stop being obnoxious.

Comment 13

[Rastignac]

> stop being obnoxious.

Hey, I'm not obnoxious at all ! That wasn't my aim, that isn't my spirit. I
don't think I'm obnoxious.  (?).

Perhaps, my previous comment missed a few smileys. Ok, perhaps.   ;)

I was so disappointed by this "not-fixed bug" that my
fast-reacting-fingers-on-keyboard went parhaps too fast...   :(

Mozilla's team is doing a great job. I'm a great Mozilla's supporter. I search
and report bugs to help Mozilla, not to be obnoxious against Mozilla's team.

I'm just sorry that "1.5" still has this bug... You know... I've waited so much...

Comment 14

[Michiel van Leeuwen (email: mvl+moz@)]

Attachment: fix assertion

This at least fixes the assertion I keep on getting. It also seems to fix the
actual problem here.

Comment 15

[[e-mail]]

Attachment: That's the way to do it!

Comment 16

[Michiel van Leeuwen (email: mvl+moz@)]

Comment on attachment 133593 [details] [diff] [review]
That's the way to do it!

Yeah, this is much better.

looking for sr.

Comment 17

[[e-mail]]

Comment on attachment 133593 [details] [diff] [review]
That's the way to do it!

BTW, I only meant to attach the first three hunks, feel free to remove the rest
if you don't want it.

Comment 18

[[e-mail]]

Attachment: Similar cleanup for popupManager.js

Comment 19

[Simon Paquet [:sipaq]]

Over to Neil, who seems to be working on this now.

Comment 20

[Brian Ryner (not reading)]

Comment on attachment 133762 [details] [diff] [review]
Similar cleanup for popupManager.js

r/sr=bryner

Comment 21

[[e-mail]]

(Assuming nobody wants it in any earlier.)

Comment 22

[[e-mail]]

Comment on attachment 133762 [details] [diff] [review]
Similar cleanup for popupManager.js

r=me, nice stuff!

Comment 23

[[e-mail]]

Fix checked in.

Comment 24

[Faxmaster]

This bug is still present in 200301104.

Comment 25

[Steffen Wilberg]

This was originally reported for Firebird, so it should be fixed in Firebird as
well. -> reopening.

Comment 26

[Steffen Wilberg]

I said reopening.

Comment 27

[Steffen Wilberg]

Attachment: port the changes from nsWalletTreeUtils.js to treeUtils.js

This merges all the differences but the license.

Comment 28

[Steffen Wilberg]

Comment on attachment 135244 [details] [diff] [review]
port the changes from nsWalletTreeUtils.js to treeUtils.js

Brian, review?
These changes should also be made to passwordManager.js, but I'm not sure about
what to change and what not.

Comment 29

[Brian Ryner (not reading)]

Comment on attachment 135244 [details] [diff] [review]
port the changes from nsWalletTreeUtils.js to treeUtils.js

r=me.  I was fairly sure I'd already cleaned up firebird's password manager
code to give the correct notifications to the tree.

Comment 30

[Brian Ryner (not reading)]

Firebird patch checked in.

Comment 31

[Steffen Wilberg]

Thanks. You're right, the password manager isn't affected by this bug. But maybe
you like the leaner sorting this bug introduced?

Comment 32

[Faxmaster]

The behavior is back to normal in 20031115.  Fix appears to be working correctly.

Comment 33

[Simon Paquet [:sipaq]]

This is fixed for firebird with bryner's checkin.

Comment 34

[Simon Paquet [:sipaq]]

verified fixed 2004-01-15

Comment 35

[Hussam Al-Tayeb]

I think this bug is back.
1. Open options and Pricacy tab
2. Open "exceptions" for cookies.
3. Delete a domain using "delete" on your keyboard.
4. Scroll down the list to see the empty space.

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7) Gecko/20040708
Firefox/0.9.0+

Comment 36

[Mike Connor [:mconnor]]

WFM on the same build.  Please file a new bug under prefs for Firefox if you can
replicate on a clean profile.

Comment 37

[:Gavin Sharp [email: [e-mail]]]

(In reply to comment #35)
> I think this bug is back.
> 1. Open options and Pricacy tab
> 2. Open "exceptions" for cookies.
> 3. Delete a domain using "delete" on your keyboard.
> 4. Scroll down the list to see the empty space.

That is bug 273698, which details a problem with the patch in this bug, notably
that the rowCount property isn't actually settable.