215668 - [FIX]prefs style sheet seems to be looked at after userContent.css

Status: VERIFIED FIXED

(Core :: CSS Parsing and Computation, defect, P2)

Description

[Michael Lefevre]

Creating a user stylesheet with this rule:

:link {
color: black;
}

has no effect - the links are still coloured according to the pref setting.

Looking at a simple page in DOMI, I see the UA styles, then my userContent.css,
and then about:PreferencesStyleSheet, which seems to be the wrong order.

According to BZ and some stuff in older bugs (e.g. bug 103594), the prefs styles
should be before the user style sheet.

I'm seeing this in trunk/2003080804/win2k.

Comment 1

[Boris Zbarsky [:bzbarsky]]

Mine.

Comment 2

[Boris Zbarsky [:bzbarsky]]

Attachment: Patch

Comment 3

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Comment on attachment 132077 [details] [diff] [review]
Patch

Sure, although the style set concept of order seems backwards.	(Why does
GatherRuleProcessors use EnumerateBackwards?)  But that seems a bit of a pain
to change, and it's even documented in nsIStyleSet.h.  (Finding nsIStyleSet.h
in the tree is left as an exercise to the reader.)

Comment 4

[Boris Zbarsky [:bzbarsky]]

Fixed.

Comment 5

[Michael Lefevre]

thanks bz.

verified working in 2003100404/win2k.