215707 - OK-button disabled after selecting incompatible theme (preferences)

Status: VERIFIED FIXED

(Firefox :: Settings UI, defect)

Description

[Stefan Eskelid]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.5b) Gecko/20030809 Mozilla Firebird/0.6.1+
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.5b) Gecko/20030809 Mozilla Firebird/0.6.1+

Selecting an old theme (eg. in the recent build, where there is the problem with
selecting the theme Mozilla Firebird), that results in the error message "You
have selected a theme designed for an earlier version...", and then moving to
another Option, like Advanced, makes the Ok-button unusable. You have to go back
to the Themes panel to make the error message appear, and Ok the message, to get
the changes saved.

Reproducible: Always

Steps to Reproduce:
1. Open Options
2. Go to themes and select 'Mozilla Firebird'
3. Go to another option (and change something)
4. The Ok-button is not responding
(5. Go back to themes, click Ok, Ok the error message, to get the changes saved)

Actual Results:  
Ok-button is not responding, due to the error message caused by the theme change.

Expected Results:  
When clicking Ok, the error message should appear regardles of where you are in
Options.

Comment 1

[alanjstr]

This prevents you from setting an incompatible theme.  The fact that the Default
comes up as incompatible is a different bug.

Recommend -> Invalid

Comment 2

[Stefan Eskelid]

No it doesn't. You can't set it to a incompatible theme. The error message
contains two buttons, Ok and Cancel. Ok is *uninstall the incompatible theme*
and Cancel is *don't uninstall the incompatible theme*. The message has nothing
to do with applying the theme or not.

This is about the fact that if you set a incompatible theme and then shift to a
different panel, you can no longer click Ok to save your changes. This is not,
the way it should behave. Wouldn't the best thing be to display the theme error
message as soon as you leave the theme panel, so you can deal with it right away?

(I know that the fact that the Default comes up as incompatible is a different
bug. This is not about that. BTW this has been resolved in the latest build)

Comment 3

[Mike Connor [:mconnor]]

Works for me, it actually closes the window, which isn't best, but better.

No confirmations, resolving WORKSFORME.

Comment 4

[Stefan Eskelid]

No, it does not work. Test using [Mozilla/5.0 (Windows; U; Windows NT 5.1;
en-US; rv:1.5b) Gecko/20030829 Firebird/0.6.1+ -
http://forums.mozillazine.org/viewtopic.php?t=22255] from aebrahim... Going to
Themes and setting the Theme to Mozilla Firebird (which is reported as
incompatible in this build - yes I know that's a different bug) makes the
Ok-button not working if you go to another category before clicking Ok.

Comment 5

[Steffen Wilberg]

Confirming. If you click Themes and select an incompatible theme like the
default one, OK is disabled.

Ben backed out the checkin for bug 213994. There is no error message anymore.
See bug 213994 comment 18: "Showing an alert" (or simply disabling OK) "after
the fact (and after the user may have switched away from themes and to somewhere
else) is not good enough UI to indicate that their theme choice is invalid.
Either the theme should not show up in the list or it should not be selectable
or something."

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.5b) Gecko/20030831
Firebird/0.6.1+

Comment 6

[Mike Connor [:mconnor]]

Fixed by the backout for 213994

I horked prefs :(

Comment 7

[Mike Connor [:mconnor]]

*** Bug 217936 has been marked as a duplicate of this bug. ***

Comment 8

[Steffen Wilberg]

I still see this. Clean profile. -> Reopening.
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.5b) Gecko/20030901
Firebird/0.6.1+

Comment 9

[Steffen Wilberg]

Ben, this is related to bug 214465. Can you have a look at this too, please?

Comment 10

[Mike Connor [:mconnor]]

The backout doesn't look complete, the checkin for 213994 definitely caused this
one.

*** This bug has been marked as a duplicate of 213994 ***

Comment 11

[Mike Connor [:mconnor]]

oops

Comment 12

[Shoshannah Forbes]

*** Bug 218188 has been marked as a duplicate of this bug. ***

Comment 13

[Mike Connor [:mconnor]]

I have a fix for this, but I think that the fix in 213994 is a better route to
allow this.

If we don't go with the solution in bug 213994, this will be fixed for 0.7

Comment 14

[Oleg Sidletskiy]

*** Bug 218856 has been marked as a duplicate of this bug. ***

Comment 15

[Mike Connor [:mconnor]]

Fixed by patch for 213994 (incompatible themes are no longer shown)

Comment 16

[Jeff Walden [:Waldo]]

Just to let anyone know, if you see this problem still even after installing the
9-13 nightly, it's not Firebird.  In fact, the problem you're having isn't even
the same, but it is similar - I hadn't even noticed the difference until this
was fixed.

The problem is most likely Themer is installed.  For some reason, Themer
disables the OK button if you switch through the Themes section of Options. 
Staying out of Themes keeps the OK button working, unlike this bug, which
disables OK regardless what sections you've been in.  I've filed a bug for
Themer at http://mozdev.org/bugs/show_bug.cgi?id=4634 regarding this.

Comment 17

[Simon Paquet [:sipaq]]

verified fixed 2003-11-09

Comment 18

[Mike Connor [:mconnor]]

sorry for bugspam, long-overdue mass reassign of ancient QA contact bugs,
filter on "beltznerLovesGoats" to get rid of this mass change