Closed
Bug 215735
Opened 21 years ago
Closed 21 years ago
[FIXr]DOM CSS declarations can have extra mRefCnt member
Categories
(Core :: CSS Parsing and Computation, defect, P2)
Core
CSS Parsing and Computation
Tracking
()
RESOLVED
FIXED
mozilla1.6alpha
People
(Reporter: bzbarsky, Assigned: bzbarsky)
Details
Attachments
(1 file, 1 obsolete file)
4.68 KB,
patch
|
dbaron
:
review+
dbaron
:
superreview+
|
Details | Diff | Splinter Review |
nsDOMCSSDeclaration has NS_DECL_ISUPPORTS, so gets an mRefCnt member. DOMCSSDeclarationImpl inherits from nsDOMCSSDeclaration but DOMCSSDeclarationImpl overrides addref/release to aggregate with its style rule, which means that DOMCSSDeclarationImpl has an unused mRefCnt member. The NS_DECL_ISUPPORTS should be pushed down into nsDOMCSSAttrDeclaration, and nsDOMCSSDeclaration will just have some pure virtual methods, which is fine -- we don't want anyone instantiating objects of that class anyway.
Assignee | ||
Comment 1•21 years ago
|
||
Assignee | ||
Updated•21 years ago
|
OS: Linux → All
Priority: -- → P2
Hardware: PC → All
Summary: DOM CSS declarations can have extra mRefCnt member → [FIX]DOM CSS declarations can have extra mRefCnt member
Target Milestone: --- → mozilla1.6alpha
Comment on attachment 129560 [details] [diff] [review] proposed patch >+ NS_DECL_ISUPPORTS Could you expand this, and skip the QueryInterface. I object to the existence of NS_IMPL_QUERY_INTERFACE_INHERITED0. >+NS_IMPL_ADDREF(nsDOMCSSAttributeDeclaration); >+NS_IMPL_RELEASE(nsDOMCSSAttributeDeclaration); No need for semicolons.
Assignee | ||
Updated•21 years ago
|
Attachment #129560 -
Flags: superreview?(dbaron)
Attachment #129560 -
Flags: review?(dbaron)
Assignee | ||
Updated•21 years ago
|
Attachment #129560 -
Flags: superreview?(dbaron)
Attachment #129560 -
Flags: superreview-
Attachment #129560 -
Flags: review?(dbaron)
Attachment #129560 -
Flags: review-
Assignee | ||
Comment 3•21 years ago
|
||
Attachment #129560 -
Attachment is obsolete: true
Attachment #129561 -
Flags: superreview+
Attachment #129561 -
Flags: review+
Assignee | ||
Updated•21 years ago
|
Summary: [FIX]DOM CSS declarations can have extra mRefCnt member → [FIXr]DOM CSS declarations can have extra mRefCnt member
Assignee | ||
Comment 4•21 years ago
|
||
Checked in.
Status: NEW → RESOLVED
Closed: 21 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•