215735 - [FIXr]DOM CSS declarations can have extra mRefCnt member

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, defect, P2)

Description

[Boris Zbarsky [:bzbarsky]]

nsDOMCSSDeclaration has NS_DECL_ISUPPORTS, so gets an mRefCnt member.
DOMCSSDeclarationImpl inherits from nsDOMCSSDeclaration but
DOMCSSDeclarationImpl overrides addref/release to aggregate with its style rule,
which means that DOMCSSDeclarationImpl has an unused mRefCnt member.

The NS_DECL_ISUPPORTS should be pushed down into nsDOMCSSAttrDeclaration, and
nsDOMCSSDeclaration will just have some pure virtual methods, which is fine --
we don't want anyone instantiating objects of that class anyway.

Comment 1

[Boris Zbarsky [:bzbarsky]]

Attachment: proposed patch

Comment 2

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Comment on attachment 129560 [details] [diff] [review]
proposed patch

>+  NS_DECL_ISUPPORTS

Could you expand this, and skip the QueryInterface.  I object to the existence
of NS_IMPL_QUERY_INTERFACE_INHERITED0.

>+NS_IMPL_ADDREF(nsDOMCSSAttributeDeclaration);
>+NS_IMPL_RELEASE(nsDOMCSSAttributeDeclaration);

No need for semicolons.

Comment 3

[Boris Zbarsky [:bzbarsky]]

Attachment: Patch updated to comments

Comment 4

[Boris Zbarsky [:bzbarsky]]

Checked in.