215787 - Pushing Enter key right after turning on Japanese IME with Alt key in edit box opens File menu

Status: RESOLVED FIXED

(Core :: Internationalization, defect)

Description

[Ryuichi KUBUKI]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.5b) Gecko/20030810
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.5b) Gecko/20030810

Pushing Enter key after turning on IME in multiline edit box opens File menu of
browse.

Reproducible: Always

Steps to Reproduce:
1. Set carret in some multi-line edit box, such as comment form in Bugzilla
2. Turn IME on (in my case it's Japanese IME, with Alt + hankaku/zenkaku key)
3. Push Enter key

Actual Results:  
File menu opens in the menu of navigator, as if pushed keys are Alt + F.

Expected Results:  
Carret should move to the next line.

I assume this bug was introduced in nightly builds in this month
around the same time I had found other bug 214890 that is related to
edit box and IME. 
Though only reproduceable for me is this pushing Enter key, I had
other occasions where other menu got open in editing multi-line edit
box.

Comment 1

[Hidehiro Kozawa]

I think the same phenomenon of bug 187839.

Comment 2

[Ryuichi KUBUKI]

Editing summary, it occurs in single-line edit box too, and added "Japanese" for
easy access.

Comment 3

[Ryuichi KUBUKI]

Editor: Core -> Internationalization

Comment 4

[Shotaro Kamio]

This must be a regression of Bug 212641.

Comment 5

[Shotaro Kamio]

Attachment: experimental patch

Try this experimental patch.
This patch disables the patch of Bug 212641.

Comment 6

[Ryuichi KUBUKI]

Found another testcase on Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US;
rv:1.6a) Gecko/20030926

1. Turn on Japanese IME
2. Enter some Japanese characters in edit box
3. Turn off IME
4. Push Shift + B to enter capital 'B' following Japanese characters in 2.
5. "Bookmarks" menu opens

Comment 7

[Shotaro Kamio]

Try this to reproduce, keeping in your mind on the timing and watching menu bar:
1. Pushing down Alt and Kanji keys  (Turn on or off Japanese IME)
2. Release Alt key first (Stay pushing Kanji key).
3. Release Kanji key.

I can reproduce this bug on mozilla1.5/win2k.

Comment 8

[Ryuichi KUBUKI]

*** Bug 214890 has been marked as a duplicate of this bug. ***

Comment 9

[Ryuichi KUBUKI]

This bug is major for most of Japanese users and hurts releases severely.  I
forgot to reassign at comment #3, now I do "reassign bug to owner and QA contact
of selected component"

Comment 10

[Ryuichi KUBUKI]

Editing summary, adding 'Alt key'
OS --> All

I noticed that there's another problem about this bug.

1. In an edit box, turn on Japanese IME with Alt + kanji key ("File" in menu is
focused)
2. Enter Japanese characters ("File" menu item is unfocused)
3. Turn off IME with Alt + kanji key ("File" in menu is focused)
4. Enter alphabets

In turning off IME in the step 3 "File" is focused, then the first one of the
characters entered in the step 4 is stolen focus by File menu item and not
accepted, and only the rest appears in edit box.

If Alt is not in IME hotkey there will be no such problem, but most of Japanese
users (Linux/Mac/Windows) use Alt key + some key for hotkey.

Comment 11

[Hidehiro Kozawa]

I tested patch of #5.
Bug 212641 is reproduced and this bug is not reproduced.

Japanese IME needs Alt + hankaku/zenkaku key(non charactor key)
message.

In Japan, This bug is Magor.

Comment 12

[[e-mail]]

Attachment: Proposed patch

This if clause is trying to do to much, and the two effects need to be
separated out.

Comment 13

[noririty]

bryner:
Any chance to get this fix into MOZILLA_1_6_BRANCH?

Comment 14

[Hidehiro Kozawa]

I tested patch of #12.
Japanese IME works well and no regression of Bug 212641.

Many Japanese wait this patch. Please check in 1.6 branch also.

Comment 15

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 140595 [details] [diff] [review]
Proposed patch

sr=bzbarsky

Comment 16

[[e-mail]]

Comment on attachment 140595 [details] [diff] [review]
Proposed patch

Requesting approval for this regression fix needed for Japanese users.

Comment 17

[chris hofmann]

Comment on attachment 140595 [details] [diff] [review]
Proposed patch

a=chofmann for 1.7a

Comment 18

[noririty]

I landed on trunk. Thanks, Neil!