216101 - Cursor fragments in <textarea>/<editor> after hitting DEL/BS/ENTER

Status: VERIFIED FIXED

(Core :: Web Painting, defect)

Description

[ws]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.0; de-AT; rv:1.4) Gecko/20030624
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.0; de-AT; rv:1.4) Gecko/20030624

The cursor sometimes looks ugly when hitting DEL at the end of the message, like
it's vertically cut in half, one part being the "on" and the other one the "off"
part. When moving the cursor, it will leave a thin vertical line. The line
vanishes when redrawing the window (e.g. minimize followed by a restore).

Reproducible: Always

Steps to Reproduce:
1. Start composing a new mail message
2. Place cursor in message body
3. hit DEL (cursor changes, most of the time), hit RETURN (cursor leaves a
vertical line)

(try step 3 several times, maybe after inserting a blank line)

Actual Results:  
See details, I also have a screenshot. Mail me if you want to see it.

Expected Results:  
Show a good cursor, and not leave a vertical line behind, duh ...

Default theme, mozilla is freshly installed, German version, German W2K.

Comment 1

[Karsten Düsterloh]

*** Bug 245667 has been marked as a duplicate of this bug. ***

Comment 2

[Karsten Düsterloh]

In addition to the mail editor, this bug is also visible in <textarea> elements
and the web page composer. It's visible whereever a 2px cursor is used, so
(most) Linux systems don't see this.

With the following method the reproducibility is 100%:
- Enter some empty lines
- Place the cursor before some empty lines
- Hit DEL exactly when the blinking cursor is "on"

This bug is present in 1.4, but not in 1.4a. I'll try to pin it down to a more
limited timeframe or checkin.

Comment 3

[Karsten Düsterloh]

1.4a (2003-04-01) is okay,
1.4b (2003-05-07) is broken.

Of all the trunk checkins in that period
<http://bonsai.mozilla.org/cvsquery.cgi?treeid=default&module=all&branch=HEAD&branchtype=match&dir=mozilla%2Fgfx&file=&filetype=match&who=&whotype=match&sortby=Date&hours=2&date=explicit&mindate=2003-04-01+00%3A00%3A00&maxdate=2003-05-08+00%3A00%3A00&cvsroot=%2Fcvsroot>
and the fact that this bug seems to be Windows only, I'll suspect patch
<http://bugzilla.mozilla.org/attachment.cgi?id=119533&action=view> of bug 
199159 (but I'm no expert here).

Comment 4

[Karsten Düsterloh]

Attachment: Erase caret when clearing frame refs

As expected, my first guess was completely off target. ;-)
But roc gave me a hint, and I think I've got it: 
the caret frame refs get cleared without erasing the caret first...
(And it's even a one-liner!)

Comment 5

[[e-mail]]

Fix checked in.

Comment 6

[Karsten Düsterloh]

Verified with trunk nightly 2004-06-27-08.

Comment 7

[amano]

Asking for aviary approval.

Please read comment #85 from bug 98564 before refusing the approval.

Comment 8

[Brendan Eich [:brendan]]

bernd: list bug # comment # for the auto-link magic to work.  Here's the right
form: bug 98564 comment 85 (and you might request nomination again if you really
want to, by setting blocking-aviary1.0?).

/be

Comment 9

[Scott MacGregor]

I ported this to the thunderbird 1.0 branch so I can pick up the fix for Bug #98564

Comment 10

[Martijn Wargers (dead)]

*** Bug 271043 has been marked as a duplicate of this bug. ***