Closed Bug 216222 Opened 21 years ago Closed 21 years ago

duplicate "use" in MAKE-JARS.PL

Categories

(SeaMonkey :: Build Config, defect)

Product:
SeaMonkey
Component:
Build Config
Platform:
x86
Windows XP
Type:
defect
Priority:
Not set
Severity:
trivial

Tracking

(Not tracked)

Status:
VERIFIED FIXED
Milestone:
mozilla1.7alpha

People

(Reporter: d_king, Assigned: d_king)

Details

(Whiteboard: Patch ready for 1.7a)

Attachments

(1 file, 1 obsolete file)

Patch (ready to go)
469 bytes, patch
cls
: review+
bryner
: superreview+
Details | Diff | Splinter Review 
User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.5a) Gecko/20030718
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.5a) Gecko/20030718

MAKE-JARS.PL has two "use Cwd;" lines that are very close to each other. If I
understand correctly, the second one is redundant.

Reproducible: Always

Steps to Reproduce:





Will attach a patch RSN.
Attached patch Testing patch (obsolete) — — Splinter Review 
Patch to comment out the extra "use" to make sure nothing breaks.
taking...
Assignee: mozbugs-build → d_king
Well, that was easy. 

This wont affect the resulting binaries as it's a script for creating "jars"
that was being inefficient rather than being defective.
Attachment #129827 - Attachment is obsolete: true
Comment on attachment 129828 [details] [diff] [review]
Patch (ready to go)

request for r
Attachment #129828 - Flags: review?(mozbugs-build)
Attachment #129828 - Flags: superreview?(leaf)
Comment on attachment 129828 [details] [diff] [review]
Patch (ready to go)

Do not ask mozbugs-build@seawood.org for reviews as that email is sent to
/dev/null.  And leaf's still on sabbatical.
Attachment #129828 - Flags: review?(mozbugs-build) → review+
Thanks for the "r".

I used mozbugs-build@seawood.org as that is what is listed as the Component
Owner at http://bugzilla.mozilla.org/describecomponents.cgi?product=Browser
Comment on attachment 129828 [details] [diff] [review]
Patch (ready to go)

Changing SR requestee.
Attachment #129828 - Flags: superreview?(leaf) → superreview?(brendan)
Comment on attachment 129828 [details] [diff] [review]
Patch (ready to go)

Build system stuff doesn't need sr=, but I'd like bryner to look at this.  I
assume it can wait for the 1.7a trunk to be checked in.

/be
Attachment #129828 - Flags: superreview?(brendan) → superreview?(bryner)
This patch can wait.....everything seems to work fine without the patch, so it's
more of a cosmetic thing.
Attachment #129828 - Flags: superreview?(bryner) → superreview+
Thanks for the reviews, this patch is ready to go in for 1.7a.
Whiteboard: Patch ready for 1.7a
Target Milestone: --- → mozilla1.7alpha
It looks like this change was already made in revision 3.61 of make-jars.pl.
Status: NEW → RESOLVED
Closed: 21 years ago
Resolution: --- → FIXED
Yup, got fixed via Bug #75687
v'ing
Status: RESOLVED → VERIFIED
Product: Browser → Seamonkey
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: