Closed
Bug 216222
Opened 22 years ago
Closed 21 years ago
duplicate "use" in MAKE-JARS.PL
Categories
(SeaMonkey :: Build Config, defect)
Tracking
(Not tracked)
VERIFIED
FIXED
mozilla1.7alpha
People
(Reporter: d_king, Assigned: d_king)
Details
(Whiteboard: Patch ready for 1.7a)
Attachments
(1 file, 1 obsolete file)
|
469 bytes,
patch
|
cls
:
review+
bryner
:
superreview+
|
Details | Diff | Splinter Review |
User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.5a) Gecko/20030718
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.5a) Gecko/20030718
MAKE-JARS.PL has two "use Cwd;" lines that are very close to each other. If I
understand correctly, the second one is redundant.
Reproducible: Always
Steps to Reproduce:
Will attach a patch RSN.
|
Assignee | |
Comment 1•22 years ago
|
||
Patch to comment out the extra "use" to make sure nothing breaks.
|
|
Assignee | |
Comment 3•22 years ago
|
||
Well, that was easy.
This wont affect the resulting binaries as it's a script for creating "jars"
that was being inefficient rather than being defective.
Attachment #129827 -
Attachment is obsolete: true
|
|
Assignee | |
Comment 4•22 years ago
|
||
Comment on attachment 129828 [details] [diff] [review]
Patch (ready to go)
request for r
Attachment #129828 -
Flags: review?(mozbugs-build)
|
|
Assignee | |
Updated•22 years ago
|
Attachment #129828 -
Flags: superreview?(leaf)
Comment on attachment 129828 [details] [diff] [review]
Patch (ready to go)
Do not ask mozbugs-build@seawood.org for reviews as that email is sent to
/dev/null. And leaf's still on sabbatical.
Attachment #129828 -
Flags: review?(mozbugs-build) → review+
|
|
Assignee | |
Comment 6•21 years ago
|
||
Thanks for the "r".
I used mozbugs-build@seawood.org as that is what is listed as the Component
Owner at http://bugzilla.mozilla.org/describecomponents.cgi?product=Browser
|
|
Assignee | |
Comment 7•21 years ago
|
||
Comment on attachment 129828 [details] [diff] [review]
Patch (ready to go)
Changing SR requestee.
Attachment #129828 -
Flags: superreview?(leaf) → superreview?(brendan)
|
||
Comment 8•21 years ago
|
||
Comment on attachment 129828 [details] [diff] [review]
Patch (ready to go)
Build system stuff doesn't need sr=, but I'd like bryner to look at this. I
assume it can wait for the 1.7a trunk to be checked in.
/be
Attachment #129828 -
Flags: superreview?(brendan) → superreview?(bryner)
|
|
Assignee | |
Comment 9•21 years ago
|
||
This patch can wait.....everything seems to work fine without the patch, so it's
more of a cosmetic thing.
|
||
Updated•21 years ago
|
Attachment #129828 -
Flags: superreview?(bryner) → superreview+
|
|
Assignee | |
Comment 10•21 years ago
|
||
Thanks for the reviews, this patch is ready to go in for 1.7a.
Whiteboard: Patch ready for 1.7a
Target Milestone: --- → mozilla1.7alpha
|
|
||
Comment 11•21 years ago
|
||
It looks like this change was already made in revision 3.61 of make-jars.pl.
Status: NEW → RESOLVED
Closed: 21 years ago
Resolution: --- → FIXED
|
||
Updated•20 years ago
|
Product: Browser → Seamonkey
You need to log in
before you can comment on or make changes to this bug.
Description
•