216243 - "browser, file, save page as" to a write protected media: no error message

Status: RESOLVED FIXED

(Core Graveyard :: File Handling, defect, P1)

Description

[Ben.Verloop]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.5a) Gecko/20030718
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.5a) Gecko/20030718

File, Save page as, to write protect media doesn't give an error message.
Mozilla should report that the media is write protected


Reproducible: Always

Steps to Reproduce:
1. Start Mozilla Build ID 2003071814
2. Menu: File, Save page as
3. Select a write protected media as destination for the file

Actual Results:  
The media did not contain the file. Unexpected, because I did not knew the media
was write protected. 

Expected Results:  
Report that the media is write protected

The media is a TS128MJFLASHA USB Device

Comment 1

[Frank Wein [:mcsmurf]]

Shouldn't the OS file saving dialog give out a warning here (also Mozilla says
Download completed if you ignore that warning)?

Comment 2

[Matthias Versen [:Matti]]

-> File Handling

Comment 3

[Darin Fisher]

biesi: you have time to look into this bug?

Comment 4

[Christian :Biesinger (don't email me, ping me on IRC)]

ok

Comment 5

[Christian :Biesinger (don't email me, ping me on IRC)]

found the bug. need to pass OFN_PATHMUSTEXIST as well, otherwise
OFN_NOREADONLYRETURN is ignored. (in windows/nsFilePicker.cpp).

note that linux does not have this bug.

Comment 6

[Christian :Biesinger (don't email me, ping me on IRC)]

Attachment: patch

Comment 7

[Darin Fisher]

Comment on attachment 130009 [details] [diff] [review]
patch

sr=darin

Comment 8

[Christian :Biesinger (don't email me, ping me on IRC)]

Comment on attachment 130009 [details] [diff] [review]
patch

should be a low-risk change

Comment 9

[Mike Kaply [:mkaply]]

Comment on attachment 130009 [details] [diff] [review]
patch

a=mkaply

Comment 10

[Christian :Biesinger (don't email me, ping me on IRC)]

Checking in src/windows/nsFilePicker.cpp;
/cvsroot/mozilla/widget/src/windows/nsFilePicker.cpp,v  <--  nsFilePicker.cpp
new revision: 1.69; previous revision: 1.68
done