216482 - Firebird Crashes when picked "View -> By Date and Site" or View-> By Site" in history sidebar

Status: RESOLVED FIXED

(Core :: XUL, defect)

Description

[Geoff Wilson]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.5b) Gecko/20030817 Mozilla Firebird/0.6.1+
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.5b) Gecko/20030817 Mozilla Firebird/0.6.1+

This has only appeared in todays nightly 17th August, when I search for a
history item, then try and go back to the full history list using "View -> By
Site" etc.. Firebird crashes with no error, only the netscape feedback window thing.

Reproducible: Always

Steps to Reproduce:
1. Open Firebird
2. Search for a history item
3. pick "View -> By Date & Site"

Actual Results:  
Firebird disappeared (crashed) Netscape Quality Feeback window appeared

Expected Results:  
show all History items

Comment 1

[Geoff Wilson]

FYI: new install / clean profile running default theme /w no Extensions, still
crashes every time.

Comment 2

[James Ross]

Confirming on Windows 2000, build 20030817. Talkback ID TB22829351E.

I couldn't get my previous build (20030816) to crash, though.

Comment 3

[James Ross]

FWIW, Firebird manages to redraw the tree under the text box with what appears
to be the correct stuff, and then crashes - /before/ redrawing the main content
(so when it crashes the half of the menu over the web page is still visible,
while the left bit, over the history view, isn't).

Another Talkback ID, TB22829613K.

Comment 4

[Chris Thomas (CTho) [formerly [e-mail] [e-mail]]]

Attachment: stack

Blew up with a stack overflow.	Can also be reproduced by selecting view by
date.

WFM Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.5b) Gecko/20030802
Mozilla Firebird/0.6.1, so it is a fairly recent introduction.

Comment 5

[Neil Jenkins]

This crash happens whatever option you select in the dropdown box - not just "By
Date or Site" or "By Site".

Should this be targeted for 0.7 as this is likely to be a common crash and
results in data loss (whatever pages you are looking at)?

Comment 6

[[e-mail]]

Attachment: Proposed patch

Comment 7

[Chris Thomas (CTho) [formerly [e-mail] [e-mail]]]

Your patch works for me.  For some reason, the results list is scrolled down
beyond the end of actual results, but that was the behavior in my older build too.

Comment 8

[jag (Peter Annema)]

Comment on attachment 130053 [details] [diff] [review]
Proposed patch

Hmm, I thought you had already removed this? Anyway, sr=jag

Comment 9

[Jonathan Dance]

Verifying for
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.5b) Gecko/20030820 Mozilla
Firebird/0.6.1+

Comment 10

[aleksr_si]

The same thing happens on Linux i686, with a segmentation fault
(MozillaFirebird/run-mozilla.sh: line 454:   822 Segmentation fault      "$prog"
${1+"$@"}) ...

Either way -- a somewhat unrelated issue, however it is mentioned in this bug
and I am reluctant to file a new one in case this is as intended, however
shouldn't "By Date and Site" be "By Date and Time"?

Comment 11

[Steven Stern]

*** Bug 216892 has been marked as a duplicate of this bug. ***

Comment 12

[[e-mail]]

Moving to correct component as this is actually an XPFE bug that hit the bird.

Comment 13

[[e-mail]]

Comment on attachment 130053 [details] [diff] [review]
Proposed patch

Need this in trunk to remove potential crasher (problem is more noticable in
firebird).

Comment 14

[Oleg Sidletskiy]

*** Bug 216987 has been marked as a duplicate of this bug. ***

Comment 15

[Ben Goodger (use ben at mozilla dot org for email)]

What exactly are you doing?

In the future, if you want approval for something urgently, it'd be nice if you
described what your code was doing in the bug. 

Comment 16

[Mike Kaply [:mkaply]]

Comment on attachment 130053 [details] [diff] [review]
Proposed patch

a=mkaply for 1.5b.

Get in ASAP

For the record, these calls are being removed because they lead to recursive
runaway.

Comment 17

[(not reading, please use [e-mail] instead)]

over to neil, since it is his patch.

neil, can you get this in for 1.5 final?

Comment 18

[[e-mail]]

Fix checked in to the trunk.