216509 - Download more in spellchecker's language pull down does not work

Status: RESOLVED FIXED

(Thunderbird :: Message Compose Window, defect)

Description

[John F. Herminghaus]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.5a) Gecko/20030718
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.5a) Gecko/20030718

When using the spellcheck clicking on "Download more" in the language box does
not produce any results.  

Reproducible: Always

Steps to Reproduce:
1. Open spellcheck
2. Click on language 
3. Click on "download more"

Actual Results:  
nothing

Expected Results:  
Opening of window such as Mozilla Cafe with a list of available languages

Comment 1

[Bronson C. Elliott]

I can confirm this using 0.2a (20030813) on Windows XP.

Comment 2

[Malte Rücker (mbr)]

Three notes/necessary steps:
1.) content/communicator/builtinURLs.js is not packaged for Thunderbird. This is
why nothing happens after clicking on "download more".

2.) builtinURLs.js function needs to be adapted to open a new browser window
(currently works in seamonkey only).

3.) bug 218120 needs to be fixed in order to display the appropriate download
page (and not a blank one).

Comment 3

[Malte Rücker (mbr)]

Points 1 & 3 from comment 2 are fixed now.

Comment 4

[Malte Rücker (mbr)]

*** Bug 227910 has been marked as a duplicate of this bug. ***

Comment 5

[Calum Mackay]

*** Bug 228860 has been marked as a duplicate of this bug. ***

Comment 6

[Peter]

Also seeing this on Thunderbird 0.5 under Windows XP, with the slight difference
to comment 1 that instead of seeing "nothing" a small windows (showing title bar
only) appears.

See also http://forums.mozillazine.org/viewtopic.php?t=55348

Also suggest someone add "dictionaries" and/or "dictionary" to the summary to
make this bug easier to find.

Comment 7

[Oleg Sidletskiy]

*** Bug 230686 has been marked as a duplicate of this bug. ***

Comment 8

[Oleg Sidletskiy]

*** Bug 238490 has been marked as a duplicate of this bug. ***

Comment 9

[Oleg Sidletskiy]

*** Bug 234994 has been marked as a duplicate of this bug. ***

Comment 10

[David Björklund]

Why hasn't this bug a target milestone?

Comment 11

[Morten Andersen]

I upgraded to Thunderbird 0.6 today with the installer. I use windows xp pro. 

Now when I pressing the Download more I get an error.

"The file /content/navigator.xul cannot be found. Please check location and try
again."

Comment 12

[Trond Danielsen]

I get the same message using thunderbird 0.6 in linux (fedora core 2 test3).

Comment 13

[Pau Montero Parés]

The same with Thunderbird 0.6 on MacOS X 10.3

Comment 14

[Ludovic Hirlimann [:Usul]]

*** Bug 243976 has been marked as a duplicate of this bug. ***

Comment 15

[Jon Henry]

I have a patch for this, with one(?) issue. The patch makes the spellchecker
just launch the user's default browser rather than assuming they run SeaMonkey.
This works fine on my WinXP machine, but does this fix make sense for *NIX
platforms? I can't find a way to do any fancy #ifdef's for that, because the
preprocessor doesn't appear to run when mozilla/editor is built. The other side
effect of this is that, if for some inexplicable reason the user's default
browser is Firefox but they're using SeaMonkey's MailNews reader, when they
click "Download More" Firefox will load and downloading the new dictionary from
there wouldn't install it in SeaMonkey as the user expects.

Would this solution be satisfactory, or is there a better fix I don't know about?

Comment 16

[Scott MacGregor]

Patrick that sounds fine.

We'll have to fork the spell checker files for Thunderbird. These changes should
not go into seamonkey. Thus avoiding the complications you referred to.

Comment 17

[Jon Henry]

Ok, I guess I'll hold off on posting that patch since forking that will be
non-trivial.

Also, FWIW I'm not sure where "Patrick" came from :)

Comment 18

[Scott MacGregor]

Sorry Jon :)

The fork should be trivial. Feel free to just post the diff and I'll fork it. 

I'm assuming you just needed to change the spell checker .xul and .js file.
That's what I was planning on doing to fix it anyway.

Comment 19

[Jon Henry]

Attachment: Patch

Alrighty. I didn't see an obvious change that needed to be made in the XUL
file, but I did put a URL into builtInURLs.rdf, as I saw was done for SeaMonkey
in an earlier bug.

Comment 20

[Scott MacGregor]

Attachment: the fix adapted for thunderbird with a forked version of the spell check JS file

Comment 21

[Scott MacGregor]

fixed on the trunk and on the branch. Thanks Jon!