216512 - X-remote code leaks gdk windows

Status: RESOLVED FIXED

(Core Graveyard :: X-remote, defect, P3)

Description

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

The X-Remote code leaks GDK Windows because it doesn't destroy its window until
after the event loop has stopped running:

gdk_superwin_destroy
(/builds/trunk/mozilla/widget/src/gtksuperwin/gdksuperwin.cgtk_marshal_NONE__NONE
(/usr/lib/libgtk-1.2.so.0)
gtk_signal_set_funcs (/usr/lib/libgtk-1.2.so.0)
gtk_signal_emit (/usr/lib/libgtk-1.2.so.0)
gtk_object_destroy (/usr/lib/libgtk-1.2.so.0)
gtk_object_destroy (/usr/lib/libgtk-1.2.so.0)
gtk_widget_destroy (/usr/lib/libgtk-1.2.so.0)
nsWindow::DestroyNative()
(/builds/trunk/mozilla/widget/src/gtk/nsWindow.cpp:496nsWidget::Destroy()
(/builds/trunk/mozilla/widget/src/gtk/nsWidget.cpp:365)
nsWindow::Destroy() (/builds/trunk/mozilla/widget/src/gtk/nsWindow.cpp:407)
XRemoteService::DestroyProxyWindow()
(/builds/trunk/mozilla/xpfe/components/xremXRemoteService::Shutdown()
(/builds/trunk/mozilla/xpfe/components/xremote/src/XR./mozilla-bin+1475B
(./mozilla-bin)
main (./mozilla-bin)
__libc_start_main (/lib/tls/libc.so.6)

The two GDK windows that the superwin owns are leaked, but the leak goes away if
this code gets called while the event loop is still running.


I'll attach a patch that fixes the leak, although it's not ideal.  In
particular, I'm a little puzzled as to why adding the observer inside
CreateProxyWindow doesn't work.

Comment 1

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Attachment: patch

Comment 2

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Fix checked in to trunk, 2003-09-17 16:46 -0700.