216722 - Inital focus in Help|About Mozilla Firefox should be "OK"

Status: RESOLVED FIXED

(Firefox :: General, defect)

Description

[grant.abraham]

User-Agent:       Mozilla/5.0 (Windows; U; Win98; en-US; rv:1.5b) Gecko/20030817 Mozilla Firebird/0.6.1+
Build Identifier: Mozilla/5.0 (Windows; U; Win98; en-US; rv:1.5b) Gecko/20030817 Mozilla Firebird/0.6.1+

The inital focus in Help|About Mozilla Firebird should be on the "OK" button
when you first open that dialog.

Reproducible: Always

Steps to Reproduce:
1. Click Help menu
2. Click "About Mozilla Firebird"

Actual Results:  
Selection focus was not on the "OK" button.

Expected Results:  
Selection focus should default to the "OK" button.

Comment 1

[Jesse Ruderman]

http://lxr.mozilla.org/mozilla/source/toolkit/content/widgets/dialog.xml#145
focuses the first focusable element in the dialog.  In the About dialog, that's
the user-agent textarea, which is readonly but not disabled.  We could fix this
bug by making the function in dialog.xml skip readonly elements, but it would be
simpler to make aboutDialog.xml focus the correct element.

Comment 2

[Jesse Ruderman]

Attachment: patch: make aboutDialog.xul focus the OK button

Comment 3

[Pierre Chanial]

what happens here is that dialog.xml inhibits the return key in focused textarea
even if it is read-only.
Either, we prohibit readonly textarea from getting the focus in
nsEventStateManager::GetNextTabbableContent (I'd prefer that but I am not sure
whether it is an accessibility pb) or we do the check for the read-only
attribute in dialog.xml in _hitEnter (or we use a <description> instead of a
<textbox> in nsAboutDialog.xul, but I haven't try if it solves the pb)
Thoughts?

note for self (there is a typo in nsEventStateManager: DEBUG_DOCSHEL_FOCUS
instead of ...SHELL...)

Comment 4

[Boris Zbarsky [:bzbarsky]]

"readonly" inputs can be tabbed to, selected via keyboard, and copied... that's
one major difference between "readonly" and "disabled".

Comment 5

[Jesse Ruderman]

Changing _hitEnter wouldn't completely fix the problem in the About dialog
because it would fix Enter but not Space.  (I first encountered this bug by
pressing Space.)  I think any correct fix has to make the OK button get focus.

Comment 6

[Adam Becevello]

*** Bug 225113 has been marked as a duplicate of this bug. ***

Comment 7

[grant.abraham]

Wondering if anyone is still working on this.

As an aside, on MSIE6, the about dialog defaults to the okay button.

Comment 8

[Samir L. Boulema]

confirming.
Firebird 0.8.0+ (20040120) on XP

Comment 9

[Steffen Wilberg]

Comment on attachment 133736 [details] [diff] [review]
patch: make aboutDialog.xul focus the OK button

Pierre should review this since he assigned the bug to himself and Blake hasn't
been around for months.

Comment 10

[Steffen Wilberg]

Comment on attachment 133736 [details] [diff] [review]
patch: make aboutDialog.xul focus the OK button

bitrotten. Jesse, do you want to make a new patch? You'd have to tweak the new
aboutDialog.js.

Comment 11

[Jeff Walden [:Waldo]]

Attachment: Updated and unbitrotted

The same patch as before, but now applied to aboutDialog.js.

Comment 12

[Jeff Walden [:Waldo]]

I've managed to get access to a computer for a sec, so nominating a few polish
bugs for Firefox 1.0...

Comment 13

[Mike Connor [:mconnor]]

Comment on attachment 141837 [details] [diff] [review]
Updated and unbitrotted

right line, wrong spot.  (if you're going to monkey with focus, do it after
everything else)

r=me with that

Comment 14

[R.J. Keller]

Fix checked in on the aviary branch and on the trunk.

Comment 15

[Mike Connor [:mconnor]]

I moved the call to the end of the init function, where it belongs.

resolved FIXED