216736 - regression from patch for bug 86947

Status: RESOLVED FIXED

(Core :: Layout: Block and Inline, defect)

Description

[Darin Fisher]

3862 dbaron       3.464       nsLineBox* next = aLine.next();
3863 kipp         3.193       if ((nsnull != next) && !next->IsBlock()) {
3864                            next->MarkDirty();

here, |next| will never be null.  we need to compare next against end_lines()
instead.

Comment 1

[Darin Fisher]

Attachment: v1 patch

this patch includes a slight tweak to one of the assertions as well.

Comment 2

[Darin Fisher]

i forgot to mention that we currently hit this assertion in debug builds:

  NS_ASSERTION(mCurrent != mListLink, "running past end");

from nsLineBox.h:559

Comment 3

[Brendan Eich [:brendan]]

Comment on attachment 130107 [details] [diff] [review]
v1 patch

approved for 1.5b.

/be

Comment 4

[Brendan Eich [:brendan]]

Should this go into the 1.4.x branch too?  Please nominate the patch if so.

/be

Comment 5

[Darin Fisher]

fixed-on-trunk

Comment 6

[Asa Dotzler [:asa]]

Comment on attachment 130107 [details] [diff] [review]
v1 patch

This is not going to make 1.4.1.  Please re-request aproval after 1.4.1 ships
if you'd like to get this in for 1.4.2.

Comment 7

[Asa Dotzler [:asa]]

Comment on attachment 130107 [details] [diff] [review]
v1 patch

low risk crash fix. approved for 1.4.1.

Comment 8

[Darin Fisher]

fixed1.4.1

Comment 9

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

I just noticed the problematic pattern occured in two places and this patch only
fixed one of them.

Comment 10

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Attachment: additional patch

Comment 11

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Comment on attachment 131538 [details] [diff] [review]
additional patch

Checked in 2003-09-16 15:09 -0700.