216741 - "OK" button does not work on Fonts & Colors menu in Options

Status: VERIFIED FIXED

(Firefox :: Menus, defect)

Description

[Jeffrey Knauth]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.5b) Gecko/20030819 Mozilla Firebird/0.6.1+
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.5b) Gecko/20030819 Mozilla Firebird/0.6.1+

Clicking on the "OK" button in the Fonts & Colors menu causes no action.
The only way out of the menu is to close it or click on "Cancel".

Moreover, once you have clicked on the "OK" button (with no acceptance)
and then canceled/closed to get back to the other menus, "OK" no longer
works for those menus either.  You have to close Options and open it
again to get "OK" to work with the other menus. ("OK" does work for
those menus if you don't first take the Fonts & Colors "OK" detour.)

This may have gotten broken in the recent move of Fonts & Colors under
Web Features.  I am pretty certain the "OK" button worked in this menu
previously in Firebird 0.6.1.


Reproducible: Always

Steps to Reproduce:
1.Tools > Options > Web Features > Fonts & Colors
2.Change some menu item (this is optional)
3.Click the "OK" button.

Actual Results:  
Nothing happens.  You have to click "Cancel" or close the menu to get out.  Now
"OK" doesn't work for the other menus either.  No preferences get changed when
"OK" doesn't work.

Expected Results:  
The change should have been accepted.

Comment 1

[Frederic Bezies]

Seeing this too, on a 12 hours old CVS based build of Firebird, under WinXP-Sp1.

Comment 2

[Waheed Islam]

I started seeing this on the 20030819 build, don't know about 18th.
didn't exist in 20030817.

no javascript errors.

Comment 3

[Vignir G.]

Also, if you go into "Fonts & Colors..." and click the "OK" button (which
doesn´t work, so you have to hit "Cancel", then the "OK " button in the main
options window doesn´t work either.
The main options window "OK" button works again after clicking "Cancel" (in
"Fonts & Colors...", and "Cancel" in the main options window, and then going
back into Options.

Comment 4

[Manoj]

The Ok button works - but you have to wait for a couple of seconds for the modal
Preferences Dialog to close. Maybe the preferences changes caused the dialog to
take longer to close than earlier.

I'm using Build: Mozilla/5.0 (Windows; U; Windows NT 5.2; en-US; rv:1.5a)
Gecko/20030813 Mozilla Firebird/0.6

Comment 5

[Tadeu "Tcmjr"Junior]

I can confirm this bug.

quote from Manoj:
"The Ok button works - but you have to wait for a couple of seconds for the modal
Preferences Dialog to close. Maybe the preferences changes caused the dialog to
take longer to close than earlier."

That is not true , build [Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US;
rv:1.5b) Gecko/20030820 Mozilla Firebird/0.6.1+] which is older than
yours(08-13) and where when the real problem started.
I waited over 5 minutes and the Dialog did not close.

Comment 6

[Blake Ross]

pch fixed this with his nsWidgetStateManager.js checkin.

Comment 7

[Jeffrey Knauth]

Thanks!  I confirmed that "OK" is now OK in Mozilla/5.0 (Windows; U; Windows NT
5.1; en-US; rv:1.5b) Gecko/20030822 Mozilla Firebird/0.6.1+

Comment 8

[Simon Paquet [:sipaq]]

verified fixed.

Comment 9

[Tadeu "Tcmjr"Junior]

verified fixed
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.5b) Gecko/20030823 Mozilla
Firebird/0.6.1+