216752 - [gtk2]tooltip make mozilla crash on Solaris

Status: RESOLVED FIXED

(Core Graveyard :: GFX: Gtk, defect)

Description

[Robin Lu]

When using classic theme, mozilla init the tooltips widget in gtk2drawing.c like:

static gint
ensure_tooltip_widget()
{
    if (!gTooltipWidget) {
        gTooltipWidget = gtk_tooltips_new();
        gtk_tooltips_force_window(gTooltipWidget);
        gtk_widget_set_rc_style(gTooltipWidget->tip_window);
        gtk_widget_realize(gTooltipWidget->tip_window);
    }
    return MOZ_GTK_SUCCESS;
}
This causes crashes of mozilla on solaris as same as bug 140698 .

Comment 1

[Robin Lu]

Attachment: patch

Comment 2

[Robin Lu]

Attachment: patch sync with current trunk

Comment 3

[Brian Ryner (not reading)]

Comment on attachment 130151 [details] [diff] [review]
patch sync with current trunk

looks ok to me.

Comment 4

[Robin Lu]

Comment on attachment 130151 [details] [diff] [review]
patch sync with current trunk

Thanks, bryner!

Comment 5

[Christopher Blizzard (:blizzard)]

Comment on attachment 130151 [details] [diff] [review]
patch sync with current trunk


>-        g_object_unref(gTooltipWidget);
>+        gtk_widget_destroy(gTooltipWidget);

I think this leaves a floating tooltip widget.	If I remember correctly,
gtk_widget_destroy() does not unref, it merely destroys the representation of
it.

Comment 6

[Robin Lu]

> I think this leaves a floating tooltip widget.	If I remember correctly,
> gtk_widget_destroy() does not unref, it merely destroys the representation of
> it.

The gTooltipWidget is not a GtkTooltip any longer. It is a GtkWindow instead.
Only used for tooltip style.

Comment 7

[Christopher Blizzard (:blizzard)]

The same thing applies, though.

Comment 8

[Robin Lu]

GtkWindow is a toplevel window and no one owns it. It calls the gtk_object_sink
in its init ( see gtk_window_init in gtkwindow.c ). I think we can just call
gtk_widget_destroy as we do the same thing to gProtoWindow. Currect me if I am
wrong.

Comment 9

[Robin Lu]

checked in trunk.
bryner and blizzard, thanks!