216789 - "Server Settings" tab in "Account Settings" is too big for preferences window

Status: VERIFIED FIXED

(SeaMonkey :: MailNews: Account Configuration, defect)

Description

[Vedran Miletic]

When "Server Settings" under "Mail and Newsgroups account settings" are opened,
it is noticeable that not all preferences fit into window.

This happens both with modern and classic themes.

Comment 1

[Vedran Miletic]

.

Comment 2

[Vedran Miletic]

Attachment: Screenshot

This screenshot shows how does it look with classic theme (it's a bit more
noticeable than on modern theme).

Comment 3

[Matthias Versen [:Matti]]

Always add your build ID in a bug report and why do you don't resize the window ?

Comment 4

[Vedran Miletic]

Build ID: 2003082004
It is noticeable when using default window size, which I assumed that is what a
user can see by default. For now, I will change Severity to trivial, because it
can probably be easily fixed and it's a cosmetic bug.

Comment 5

[Ian Neal]

This can be fixed by changed the default height from 470 to 500 but, in the file
you need to alter, it does say "XUL/FE DEVELOPERS: DO NOT MODIFY THIS VALUE"
Altering it to 500 also fixes a problem with the "Offline & Disk Space" pane for
newsgroups.

Taking bug

Comment 6

[Ian Neal]

Accepting

Comment 7

[Ian Neal]

Attachment: Patch v0.1

Very simple patch to alter default height from 470 to 500. Won't fix problem
for existing users though, they would have to resize the window.

Comment 8

[Ian Neal]

Hmmm, just thought, this would make the window bigger than 640 x 480 so perhaps
it is better to resolve this bug as a nofix (probably why the "Offline & Disk
Space" pane has been left as it is).

Seth/Matti ?

Comment 9

[Vedran Miletic]

Just an idea, perhaps something in the preferences look can be altered (moving a
button or some text, for example) to fix this.

Comment 10

[Ian Neal]

Attachment: Proposed tweak to UI

Mockup of UI change in upcoming patch v0.2

Comment 11

[Ian Neal]

Attachment: Patch v0.2

This patch moves "Advanced..." button to be inline with first check box in
server settings box.

Comment 12

[Vedran Miletic]

Does that also fix "Offline & Disk Space"?

Comment 13

[Ian Neal]

No it doesn't, if you want to propose getting that fixed could you create a new
bug and perhaps, if you have one, give a suggestion of how that should be fixed.

Comment 14

[[e-mail]]

I don't like the button there... can you perhaps do something like this:
<hbox align="end">
  <vbox flex="1">
    <checkbox label="Expunge Inbox on Exit"/>
    <checkbox label="Empty Trash on Exit"/>
  </vbox>
  <button label="Advanced"/>
</hbox>

This wouldn't change the layout at all for news but I think that's ok.

Comment 15

[Ian Neal]

Attachment: Revised tweaked UI as per comment#14

Comment 16

[Ian Neal]

Attachment: Revised Patch v0.2a

Revised as per comment #14

Comment 17

[Vedran Miletic]

What else we need to get this landed?

Comment 18

[Matthias Versen [:Matti]]

a Superreview from bienvenu as you can see in the patch status (attachment box)

Comment 19

[David :Bienvenu]

Comment on attachment 130981 [details] [diff] [review]
Revised Patch v0.2a

sr=bienvenu

Comment 20

[Christian :Biesinger (don't email me, ping me on IRC)]

Checking in am-server.xul;
/cvsroot/mozilla/mailnews/base/prefs/resources/content/am-server.xul,v  <--  am-
server.xul
new revision: 1.99; previous revision: 1.98
done