216940 - mailnews channels violate nsIChannel api (contentType)

Status: VERIFIED FIXED

(MailNews Core :: Networking, defect, P1)

Description

[Christian :Biesinger (don't email me, ping me on IRC)]

nsIChannel.idl:
122      * The value of the contentType attribute is a lowercase string.  A value
123      * assigned to this attribute will be parsed and normalized as follows:
124      *  1- any parameters (delimited with a ';') will be stripped.
125      *  2- if a charset parameter is given, then its value will replace the
126      *     the contentCharset attribute of the channel.
127      *  3- the stripped contentType will be lowercased.
128      * Any implementation of nsIChannel must follow these rules.

These mailnews channels violate that api:
http://lxr.mozilla.org/seamonkey/source/mailnews/base/util/nsMsgProtocol.cpp#563
http://lxr.mozilla.org/seamonkey/source/mailnews/imap/src/nsImapProtocol.cpp#8036
http://lxr.mozilla.org/seamonkey/source/mailnews/news/src/nsNNTPProtocol.cpp#5465
(though this inherits from nsMsgProtocol)

fixing this would probably fix bug 216939, marking dependency

Comment 1

[Christian :Biesinger (don't email me, ping me on IRC)]

oh, darin mentioned:  nsNetUtil.h has a method called NS_ParseContentType that
does the right thing

Comment 2

[Christian :Biesinger (don't email me, ping me on IRC)]

Attachment: patch

Comment 3

[David :Bienvenu]

Comment on attachment 130221 [details] [diff] [review]
patch

great, thx.

Comment 4

[Darin Fisher]

Comment on attachment 130221 [details] [diff] [review]
patch

sr=darin

Comment 5

[Christopher Aillon (sabbatical, not receiving bugmail)]

Comment on attachment 130221 [details] [diff] [review]
patch

I would like to see this land, if possible, for 1.5beta.  This very small
correctness fix makes mail attachments work properly on attachments sent from
AOL Communicator (see the depent bug 216939).

Comment 6

[Mike Kaply [:mkaply]]

Comment on attachment 130221 [details] [diff] [review]
patch

get it in quick

Comment 7

[Christopher Aillon (sabbatical, not receiving bugmail)]

Comment on attachment 130221 [details] [diff] [review]
patch

I just landed this for biesi since he was idle on irc.	Thanks for the quick
fix!

Comment 8

[Christian :Biesinger (don't email me, ping me on IRC)]

Comment on attachment 130221 [details] [diff] [review]
patch

this bug also affects the 1.4 branch, so I'd like to get the patch checked in
there too. also see comment 5 for the reasoning.

Comment 9

[Asa Dotzler [:asa]]

Please resolve this if it's fixed on the trunk. 1.4.x requests will be evaluated
once the bug is resolved and verified on the trunk.

Comment 10

[Christian :Biesinger (don't email me, ping me on IRC)]

OK, marking fixed

Comment 11

[Christopher Aillon (sabbatical, not receiving bugmail)]

Verified fixed - tested on

Linux trunk 2003082505
Windows trunk 2003082404

Comment 12

[Asa Dotzler [:asa]]

Comment on attachment 130221 [details] [diff] [review]
patch

This is not going to make 1.4.1.  Please re-request aproval after 1.4.1 ships
if you'd like to get this in for 1.4.2.

Comment 13

[Mike Kaply [:mkaply]]

Comment on attachment 130221 [details] [diff] [review]
patch

a=mkaply for 1.4.2

Comment 14

[Christian :Biesinger (don't email me, ping me on IRC)]

fixed on 1.4 branch:
Checking in base/util/nsMsgProtocol.cpp;
/cvsroot/mozilla/mailnews/base/util/nsMsgProtocol.cpp,v  <--  nsMsgProtocol.cpp
new revision: 1.112.2.2; previous revision: 1.112.2.1
done
Checking in imap/src/nsImapProtocol.cpp;
/cvsroot/mozilla/mailnews/imap/src/nsImapProtocol.cpp,v  <--  nsImapProtocol.cpp
new revision: 1.492.2.2; previous revision: 1.492.2.1
done