217025 - GIF decoder cleanup

Status: RESOLVED FIXED

(Core :: Graphics: ImageLib, defect)

Description

[tor]

Late spring cleaning of the GIF decoder - removing unused state structure
members, function prototypes, and a header file.

Comment 1

[tor]

Attachment: cleanup

Comment 2

[tor]

Checked in.

Comment 3

[Christian Reis]

Comment on attachment 130243 [details] [diff] [review]
cleanup

>Index: GIF2.cpp
>@@ -930,11 +918,9 @@
>         gs->local_colormap_size = num_colors;
> 
>         /* Switch to the new local palette after it loads */
>-        gs->is_local_colormap_defined = PR_TRUE;
>         GETN(gs->local_colormap_size * 3, gif_image_colormap);
>       } else {
>         /* Switch back to the global palette */
>-        gs->is_local_colormap_defined = PR_FALSE;
>         GETN(1, gif_lzw_start);
>       }

Hmm, you might want to have cleaned up those comments, too, while you were at
it.

Comment 4

[tor]

Thanks for bringing that to my attention - upon a review of the gif
specification and the code, it turns out we weren't properly handling
the case where we're supposed to switch back to the global colormap
after finishing an image block with a local colormap.

Comment 5

[tor]

Attachment: handle switching colormaps properly

Comment 6

[Christian Reis]

Yep, I was wondering about that specific change. 

Comment 7

[tor]

Checked in.