217121 - Choosing Save Page, Image, or Link as... does nothing (Mac only)

Status: VERIFIED FIXED

(Firefox :: Menus, defect, P1)

Description

[Jerry Talkington]

User-Agent:       Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.5b) Gecko/20030823 Mozilla Firebird/0.6.1+ (jtalkington nightly)
Build Identifier: Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.5b) Gecko/20030823 Mozilla Firebird/0.6.1+ (jtalkington nightly)

Choosing Save Page/Image as... from either the regular menu or the context menu
does nothing.  No dialog, no crash, nothing.  This started a couple of days ago
with the nightlies I'm making.

Reproducible: Always

Steps to Reproduce:
1. Open a web page.
2. Chose "Save Page As..."
3. Watch the magic.

Actual Results:  
Nothing.

Expected Results:  
Saved the page.

Comment 1

[Jerry Talkington]

"Save Link To Disk..." does work, however there is no dialog box after clicking
that (the elipses indicate that there should be one.

Comment 2

[HARUNAGA Hirotoshi]

Confirmed with 2003-08-23 CVS build on OS 10.2.6.
Marking New.
It seems like this is Mac only.

Comment 3

[HARUNAGA Hirotoshi]

If I set "Save all files to this folder" in Preferences->Downloads,
only "Save link to Disk" becomes to work.

Comment 4

[Vincent Nicolas]

Confirming this bug with Gecko/20030926 Firebird/0.7 (MacOs X 10.2.6)
Contextual menu does not work either (Save image, Save link as).

Comment 5

[C Gregory]

Also confirming this bug - reproducible: always.
After selecting "Save Page/Image As..." in either the regular menu or
command-click contexual menu, nothing happens.  Am still able to save images by
dragging them to my desired location in the Finder though.

Firebird details:
Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.5) Gecko/20031003
Firebird/0.7 (MacOS 10.1.5)

Comment 6

[Jonathan Louie]

jerry, is bug 221841 a dupe of this?  save link to disk... doesnt work for me
(0.7 candidate 20030926).

Comment 7

[HARUNAGA Hirotoshi]

*** Bug 221841 has been marked as a duplicate of this bug. ***

Comment 8

[Mike Connor [:mconnor]]

*** Bug 222273 has been marked as a duplicate of this bug. ***

Comment 9

[Fabio Inguaggiato]

I confirm this bug with Firebird 0.7 [Mozilla/5.0 (Macintosh; U; PPC Mac OS X
Mach-O; en-US; rv:1.5) Gecko/20031007 Firebird/0.7] and Mac OS X 10.2.8

Comment 10

[Michael Moulton]

I am also having this problem under 0.7.  Worked under 0.6.1.

Comment 11

[HARUNAGA Hirotoshi]

We can see the following error in JavaScript Console, if we set
user_pref("javascript.options.strict", true);
user_pref("javascript.options.showInConsole", true);

Error: [Exception... "Component returned failure code: 0x80004005
(NS_ERROR_FAILURE) [nsIProperties.get]"  nsresult: "0x80004005
(NS_ERROR_FAILURE)"  location: "JS frame ::
chrome://browser/content/contentAreaUtils.js :: foundHeaderInfo :: line 264" 
data: no]
Source File: chrome://browser/content/contentAreaUtils.js
Line: 264

Comment 12

[Ben Goodger (use ben at mozilla dot org for email)]

-> me

Comment 13

[Ben Goodger (use ben at mozilla dot org for email)]

Attachment: browser/ part (use the correct directory service constant for MacOS X)

Comment 14

[Ben Goodger (use ben at mozilla dot org for email)]

Attachment: Patch for nsprpub/

P_MACOSX should be in the list of OSes that require tm.tm_zone to be set to
null... otherwise strftime gets very cranky with us (= crash).

Comment 15

[Ben Goodger (use ben at mozilla dot org for email)]

-> high priority 0.7.1 

Comment 16

[Wan-Teh Chang]

Comment on attachment 133901 [details] [diff] [review]
Patch for nsprpub/ 

r=wtc.	I will change XP_MACOSX to DARWIN when I check in
this patch.

Comment 17

[Wan-Teh Chang]

Comment on attachment 133901 [details] [diff] [review]
Patch for nsprpub/ 

Ben, could you tell me what's the format string that
you pass to PR_FormatTime to cause it to crash in strftime?
I'd like to add this test case to the NSPR test suite.
Right now NSPR's test suite is testing:
    "%c GMT"
    "%T"
    "%d %b %Y %H:%M:%S"

Comment 18

[Ben Goodger (use ben at mozilla dot org for email)]

Wan-Teh, 

I've sent you mail detailing exactly how this was being called. In summary, 

PR_FormatTime is being called with just "%Z" by PR_FormatTimeUSEnglish, which is
being called with "%a %b %d %H:%M:%S %Z %Y". Looks like nspr is missing a test
for %Z, and %Y

Comment 19

[Asa Dotzler [:asa]]

Comment on attachment 133901 [details] [diff] [review]
Patch for nsprpub/ 

a=asa (on behalf of drivers) for checkin to the 1.5 branch.

Comment 20

[Jonathan Louie]

*** Bug 222341 has been marked as a duplicate of this bug. ***

Comment 21

[Wayne Woods]

WFM 20031024 Firebird/0.7+ I guess the fix was checked into the trunk as well as
the branch. :)

Comment 22

[Ben Goodger (use ben at mozilla dot org for email)]

Fixed, 1.6a trunk and 1.5br

Comment 23

[Ben Goodger (use ben at mozilla dot org for email)]

Fixed, 1.6a trunk and 1.5br

Comment 24

[Stephen Donner [:stephend] Not actively reading bugmail]

Old, now-fixed bug that works just fine on:

Mozilla/5.0 (Macintosh; U; Intel Mac OS X; en-US; rv:1.9a7pre) Gecko/2007072004 Minefield/3.0a7pre