Closed Bug 217147 Opened 21 years ago Closed 21 years ago

"View Saved Passwords..." window doesn't remember its size and position

Categories

(Toolkit :: Password Manager, defect)

Product:
Toolkit
Component:
Password Manager
Type:
defect
Priority:
Not set
Severity:
minor

Tracking

()

Status:
VERIFIED FIXED

People

(Reporter: steffen.wilberg, Assigned: steffen.wilberg)

References

Details

Attachments

(1 file, 1 obsolete file)

patch to fix bug 205176 as well
2.82 KB, patch
bryner
: review+
bryner
: superreview+
Details | Diff | Splinter Review
The Tools-Options-Privacy-Saved Passwords-View Saved Passwords window does not remember its size and position. It should do that like the cookie manager windows do.
Attached patch patch from bug 65596 (obsolete) — — Splinter Review
I ported the checkin from bug 65596 to toolkit. The changes are identical. This patch does the following: - the initial width style is removed - position and size of the window are now persistent - the ratio Site-column-width:Username-column-width is now 5:2 instead 1:1 - the column widths are persistent, too I manually modified my toolkit.jar. Works fine.
Attachment #131837 - Flags: review?(blake)
OS: Windows XP → All
Hardware: PC → All
This fixes bug 205176 as well by removing everything that looks like "help". It's easier to combine these fixes.
Attachment #131837 - Flags: review?(blake)
Attachment #131839 - Flags: review?(blake)
Blocks: 205176
Comment on attachment 131839 [details] [diff] [review] patch to fix bug 205176 as well Brian, I just realized that you've got the full cvs blame for both files. Can you review this please?
Attachment #131839 - Flags: superreview?(bryner)
Attachment #131839 - Flags: review?(bryner)
Attachment #131839 - Flags: review?(blake)
Reassigning to bryner accordingly.
Reassigning, 2nd try.
Assignee: blake → bryner
Adding [pwd-mngr] to summary to facilitate querying on Password Manager bugs. Sorry for the bugspam.
Summary: "View Saved Passwords..." window doesn't remember its size and position → [pwd-mngr] "View Saved Passwords..." window doesn't remember its size and position
Component: Preferences → Password Manager
Comment on attachment 131839 [details] [diff] [review] patch to fix bug 205176 as well r+sr=bryner
Attachment #131839 - Flags: superreview?(bryner)
Attachment #131839 - Flags: superreview+
Attachment #131839 - Flags: review?(bryner)
Attachment #131839 - Flags: review+
checked in.
Status: NEW → RESOLVED
Closed: 21 years ago
Resolution: --- → FIXED
v. Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.6b) Gecko/20031212 Firebird/0.7+
Status: RESOLVED → VERIFIED
Summary: [pwd-mngr] "View Saved Passwords..." window doesn't remember its size and position → "View Saved Passwords..." window doesn't remember its size and position
Attachment #131837 - Attachment is obsolete: true
Product: Firefox → Toolkit
Mine.
Assignee: bryner → steffen.wilberg
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: