217147 - "View Saved Passwords..." window doesn't remember its size and position

Status: VERIFIED FIXED

(Toolkit :: Password Manager, defect)

Description

[Steffen Wilberg]

The Tools-Options-Privacy-Saved Passwords-View Saved Passwords window does not
remember its size and position.

It should do that like the cookie manager windows do.

Comment 1

[Steffen Wilberg]

Attachment: patch from bug 65596

I ported the checkin from bug 65596 to toolkit. The changes are identical.

This patch does the following:
- the initial width style is removed
- position and size of the window are now persistent
- the ratio Site-column-width:Username-column-width is now 5:2 instead 1:1
- the column widths are persistent, too

I manually modified my toolkit.jar. Works fine.

Comment 2

[Steffen Wilberg]

Attachment: patch to fix bug 205176 as well

This fixes bug 205176 as well by removing everything that looks like "help".
It's easier to combine these fixes.

Comment 3

[Steffen Wilberg]

Comment on attachment 131839 [details] [diff] [review]
patch to fix bug 205176 as well

Brian, I just realized that you've got the full cvs blame for both files. Can
you review this please?

Comment 4

[Steffen Wilberg]

Reassigning to bryner accordingly.

Comment 5

[Steffen Wilberg]

Reassigning, 2nd try.

Comment 6

[David P James]

Adding [pwd-mngr] to summary to facilitate querying on Password Manager bugs.
Sorry for the bugspam.

Comment 7

[Brian Ryner (not reading)]

Comment on attachment 131839 [details] [diff] [review]
patch to fix bug 205176 as well

r+sr=bryner

Comment 8

[Brian Ryner (not reading)]

checked in.

Comment 9

[David P James]

v.

Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.6b) Gecko/20031212 Firebird/0.7+

Comment 10

[Steffen Wilberg]

Mine.