Closed
Bug 217219
Opened 22 years ago
Closed 22 years ago
Messages in votes errors are incorrectly CHOMP'd
Categories
(Bugzilla :: User Interface, defect)
Tracking
()
RESOLVED
FIXED
Bugzilla 2.18
People
(Reporter: timeless, Assigned: timeless)
References
Details
Attachments
(1 file, 2 obsolete files)
|
1.43 KB,
patch
|
kiko
:
review+
|
Details | Diff | Splinter Review |
Comment on attachment 130363 [details] [diff] [review]
avoid POST_CHOMP
i find numbers at the end of sentences to be a bit awkward.
should i add ' votes' to the tail of the sentences?
Attachment #130363 -
Flags: review?(justdave)
|
||
Comment 3•22 years ago
|
||
Yes, adding a " votes" wouldn't hurt.
Gerv
|
||
Comment 4•22 years ago
|
||
Comment on attachment 130363 [details] [diff] [review]
avoid POST_CHOMP
r= justdave if you fix your nits from comment 2
Attachment #130363 -
Flags: review?(justdave) → review+
|
|
||
Updated•22 years ago
|
Severity: normal → trivial
OS: Windows 2000 → All
Hardware: PC → All
Target Milestone: --- → Bugzilla 2.18
|
|
||
Comment 5•22 years ago
|
||
Comment on attachment 130363 [details] [diff] [review]
avoid POST_CHOMP
nevermind, it's way bitrotted. :)
Attachment #130363 -
Flags: review+ → review-
|
|
||
Comment 6•22 years ago
|
||
and there's now two instances of this issue to fix in the same error message.
Attachment #130363 -
Attachment is obsolete: true
Attachment #131459 -
Flags: review?(justdave)
|
||
Comment 8•22 years ago
|
||
Comment on attachment 131459 [details] [diff] [review]
that's the problem with waiting for approval
> should i add ' votes' to
> the tail of the sentences?
Well?
Attachment #131459 -
Flags: review?(justdave) → review-
|
|
||
Comment 9•22 years ago
|
||
Comment on attachment 131459 [details] [diff] [review]
that's the problem with waiting for approval
And shouldn't you be using [%+ there instead of line break hacks?
(It would be really nice if the bug summary actually explained what the bug in
this case is :-P)
|
Assignee | |
Comment 10•22 years ago
|
||
Attachment #131459 -
Attachment is obsolete: true
|
|
||
Updated•22 years ago
|
Attachment #134256 -
Flags: review+
|
|
||
Updated•22 years ago
|
Status: NEW → ASSIGNED
Flags: approval?
Summary: Votes errors are POST_CHOMP'd → Messages in votes errors are incorrectly CHOMP'd
|
|
||
Updated•22 years ago
|
Flags: approval? → approval+
|
|
Assignee | |
Comment 11•22 years ago
|
||
checked in
Status: ASSIGNED → RESOLVED
Closed: 22 years ago
Resolution: --- → FIXED
|
||
Updated•12 years ago
|
QA Contact: matty_is_a_geek → default-qa
You need to log in
before you can comment on or make changes to this bug.
Description
•