217257 - decodeURIComponent() produces wrong result

Status: RESOLVED FIXED

(Rhino Graveyard :: Core, defect)

Description

[Larry Blair]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.3) Gecko/20030312
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.3) Gecko/20030312

Under Rhino 1.5R4.1, decodeURIComponent() overwrites everything before the first
'%' in its result.



Reproducible: Always

Steps to Reproduce:
1. java Shell
2. js>var u = "http%3a%2f%2fmozilla%2ffoo.html"; decodeURIComponent(u);

Actual Results:  
://mozilla/foo.html

Expected Results:  
http://mozilla/foo.html

I have fixed this bug on my system.  The problem is in
org.mozilla.javascript.NativeGlobal.decode(Context, String, boolean).  Here is a
code snippet:

                if (buf == null) {
                    // decode always compress so result can not be bigger then
                    // str.length()
                    buf = new char[length];
                    str.getChars(0, k, buf, 0);
                    bufTop = k; // <- I added this line ***
                }

Comment 1

[Phil Schwartau]

cc'ing Igor -

Comment 2

[Igor Bukanov]

I committed the fix. Thanks for reporting this!

Comment 3

[Igor Bukanov]

Trageting as resolved against 1.5R5